Issue 23554002: Remove implementation of CpuProfileNode methods deprecated in v8 3.20

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23554002: Remove implementation of CpuProfileNode methods deprecated in v8 3.20 (Closed)

Created:
7 years, 3 months ago by yurys

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer, Sven Panne, Yang, loislo

CC:
v8-dev, alph

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove implementation of CpuProfileNode methods deprecated in v8 3.20 GetTotalTime, GetSelfTime and GetTotalSamplesCount were deprecated in 3.20 (https://code.google.com/p/v8/source/browse/branches/3.20/include/v8-profiler.h) and can be safely removed. BUG=None R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16367

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -158 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	src/profile-generator.h	View	5 chunks	+0 lines, -15 lines	0 comments	Download
M	src/profile-generator.cc	View	4 chunks	+2 lines, -57 lines	0 comments	Download
M	src/profile-generator-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-profile-generator.cc	View	9 chunks	+0 lines, -49 lines	0 comments	Download

Total messages: 5 (0 generated)

yurys

7 years, 3 months ago (2013-08-27 15:12:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r16367 (presubmit successful).