Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/ntp_snippets/ntp_snippets_database.cc

Issue 2355393002: New snippets now replace old snippets and do not merge (Closed)
Patch Set: Minor polish Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/ntp_snippets_database.cc
diff --git a/components/ntp_snippets/ntp_snippets_database.cc b/components/ntp_snippets/ntp_snippets_database.cc
index 547aaa16aa5749739bae34587e68fe95d628d8de..1ec94cb39a57f62a76775b1ed746e2de8142954b 100644
--- a/components/ntp_snippets/ntp_snippets_database.cc
+++ b/components/ntp_snippets/ntp_snippets_database.cc
@@ -22,7 +22,7 @@ const char kImageDatabaseUMAClientName[] = "NTPSnippetImages";
const char kSnippetDatabaseFolder[] = "snippets";
const char kImageDatabaseFolder[] = "images";
-}
+} // namespace
namespace ntp_snippets {
@@ -125,6 +125,14 @@ void NTPSnippetsDatabase::DeleteImage(const std::string& snippet_id) {
DeleteImagesImpl(base::MakeUnique<std::vector<std::string>>(1, snippet_id));
}
+void NTPSnippetsDatabase::DeleteImages(const NTPSnippet::PtrVector& snippets) {
+ std::unique_ptr<std::vector<std::string>> keys_to_remove(
+ new std::vector<std::string>());
+ for (const std::unique_ptr<NTPSnippet>& snippet : snippets)
+ keys_to_remove->emplace_back(snippet->id());
+ DeleteImagesImpl(std::move(keys_to_remove));
+}
+
void NTPSnippetsDatabase::OnDatabaseInited(bool success) {
DCHECK(!database_initialized_);
if (!success) {
@@ -256,8 +264,6 @@ void NTPSnippetsDatabase::DeleteSnippetsImpl(
std::unique_ptr<std::vector<std::string>> keys_to_remove) {
DCHECK(IsInitialized());
- DeleteImagesImpl(base::MakeUnique<std::vector<std::string>>(*keys_to_remove));
-
std::unique_ptr<KeyEntryVector> entries_to_save(new KeyEntryVector());
database_->UpdateEntries(std::move(entries_to_save),
std::move(keys_to_remove),

Powered by Google App Engine
This is Rietveld 408576698