Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: components/ntp_snippets/content_suggestions_service.h

Issue 2355393002: New snippets now replace old snippets and do not merge (Closed)
Patch Set: Marc's comments #5 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.h
diff --git a/components/ntp_snippets/content_suggestions_service.h b/components/ntp_snippets/content_suggestions_service.h
index 8b9c1eec7e2b94cf0205cc7490e4d2ee322bebea..a038fbfe830127433d161baf47b659f18e3f064e 100644
--- a/components/ntp_snippets/content_suggestions_service.h
+++ b/components/ntp_snippets/content_suggestions_service.h
@@ -212,9 +212,8 @@ class ContentSuggestionsService : public KeyedService,
bool RegisterCategoryIfRequired(ContentSuggestionsProvider* provider,
Category category);
- // Removes a suggestion from the local stores |id_category_map_| and
- // |suggestions_by_category_|, if it exists. Returns true if a suggestion was
- // removed.
+ // Removes a suggestion from the local store |suggestions_by_category_|, if it
+ // exists. Returns true if a suggestion was removed.
bool RemoveSuggestionByID(Category category,
const std::string& suggestion_id);
@@ -251,11 +250,6 @@ class ContentSuggestionsService : public KeyedService,
std::map<Category, std::vector<ContentSuggestion>, Category::CompareByID>
suggestions_by_category_;
- // Map used to determine the category of a suggestion (of which only the ID
- // is available). This also determines the provider that delivered the
- // suggestion.
- std::map<std::string, Category> id_category_map_;
-
// Observer for the HistoryService. All providers are notified when history is
// deleted.
ScopedObserver<history::HistoryService, history::HistoryServiceObserver>
« no previous file with comments | « components/ntp_snippets/content_suggestions_provider.cc ('k') | components/ntp_snippets/content_suggestions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698