New snippets now replace old snippets and do not merge

components/ntp_snippets/ntp_snippets_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_service.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 622 matching lines @@
 
   std::string json_str(GetTestJson({GetSnippet()}));
 
   LoadFromJSONString(service.get(), json_str);
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), SizeIs(1));
 
   service->ClearCachedSuggestions(articles_category());
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
 }
 
-TEST_F(NTPSnippetsServiceTest, InsertAtFront) {
+TEST_F(NTPSnippetsServiceTest, ReplaceSnippets) {
   auto service = MakeSnippetsService();
 
   std::string first("http://first");
   LoadFromJSONString(service.get(), GetTestJson({GetSnippetWithUrl(first)}));
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()),
               ElementsAre(IdEq(first)));
 
   std::string second("http://second");
   LoadFromJSONString(service.get(), GetTestJson({GetSnippetWithUrl(second)}));
   // The snippet loaded last should be at the first position in the list now.

[Marc Treib, 2016/09/23 16:36:06]

nit: This comment could be updated

[jkrcal, 2016/09/23 17:34:32]

Oh, thanks, I missed it!

   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()),
-              ElementsAre(IdEq(second), IdEq(first)));
-}
-
-TEST_F(NTPSnippetsServiceTest, LimitNumSnippets) {
-  auto service = MakeSnippetsService();
-
-  int max_snippet_count = NTPSnippetsService::GetMaxSnippetCountForTesting();
-  int snippets_per_load = max_snippet_count / 2 + 1;
-  char url_format[] = "http://localhost/%i";
-
-  std::vector<std::string> snippets1;
-  std::vector<std::string> snippets2;
-  for (int i = 0; i < snippets_per_load; i++) {
-    snippets1.push_back(GetSnippetWithUrl(base::StringPrintf(url_format, i)));
-    snippets2.push_back(GetSnippetWithUrl(
-        base::StringPrintf(url_format, snippets_per_load + i)));
-  }
-
-  LoadFromJSONString(service.get(), GetTestJson(snippets1));
-  ASSERT_THAT(service->GetSnippetsForTesting(articles_category()),
-              SizeIs(snippets1.size()));
-
-  LoadFromJSONString(service.get(), GetTestJson(snippets2));
-  EXPECT_THAT(service->GetSnippetsForTesting(articles_category()),
-              SizeIs(max_snippet_count));
+              ElementsAre(IdEq(second)));
 }
 
 TEST_F(NTPSnippetsServiceTest, LoadInvalidJson) {
   auto service = MakeSnippetsService();
 
   LoadFromJSONString(service.get(), GetTestJson({GetInvalidSnippet()}));
   EXPECT_THAT(service->snippets_fetcher()->last_status(),
               StartsWith("Received invalid JSON"));
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
 }
@@ skipping 108 matching lines @@
   std::string json =
       GetSnippetWithTimes(GetDefaultCreationTime(), GetDefaultExpirationTime());
   base::ReplaceFirstSubstringAfterOffset(
       &json, 0, FormatTime(GetDefaultCreationTime()), "aaa1448459205");
   std::string json_str(GetTestJson({json}));
 
   LoadFromJSONString(service.get(), json_str);
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
 }
 
-TEST_F(NTPSnippetsServiceTest, RemoveExpiredContent) {
+TEST_F(NTPSnippetsServiceTest, RemoveExpiredDismissedContent) {
+  auto service = MakeSnippetsService();
+
+  std::string json_str1(GetTestJson({GetExpiredSnippet()}));
+  // Load it.
+  LoadFromJSONString(service.get(), json_str1);
+  // Dismiss the suggestion
+  service->DismissSuggestion(
+      service->MakeUniqueID(service->articles_category_, kSnippetUrl));
+
+  // Load a different snippet - this will clear the expired dismissed ones.

[Marc Treib, 2016/09/23 16:36:06]

This seems to test an implementation details that doesn't really matter, but I
guess we don't have a better "event" to trigger the actual removal of the
expired dismissed stuff?

[jkrcal, 2016/09/23 17:34:32]

I agree it is an implementation detail but this way it actually also makes sure
it happens frequently enough (upon each fetch).

+  std::string json_str2(GetTestJson({GetSnippetWithUrl(kSnippetUrl2)}));
+  LoadFromJSONString(service.get(), json_str2);
+
+  EXPECT_THAT(service->GetDismissedSnippetsForTesting(articles_category()),
+              IsEmpty());
+}
+
+TEST_F(NTPSnippetsServiceTest, ExpiredContentNotRemoved) {
   auto service = MakeSnippetsService();
 
   std::string json_str(GetTestJson({GetExpiredSnippet()}));
 
   LoadFromJSONString(service.get(), json_str);
-  EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
+  EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), SizeIs(1));
 }
 
 TEST_F(NTPSnippetsServiceTest, TestSingleSource) {
   auto service = MakeSnippetsService();
 
   std::string json_str(GetTestJson({GetSnippetWithSources(
       "http://source1.com", "Source 1", "http://source1.amp.com")}));
 
   LoadFromJSONString(service.get(), json_str);
   ASSERT_THAT(service->GetSnippetsForTesting(articles_category()), SizeIs(1));
@@ skipping 219 matching lines @@
              end = base::Time::FromTimeT(456);
   base::Callback<bool(const GURL& url)> filter;
   service->ClearHistory(begin, end, filter);
 
   EXPECT_THAT(service->GetSnippetsForTesting(articles_category()), IsEmpty());
   EXPECT_THAT(service->GetDismissedSnippetsForTesting(articles_category()),
               IsEmpty());
 }
 
 }  // namespace ntp_snippets