Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2355373002: [turbofan] Pre-spill ranges that have a slot use. (Closed)

Created:
4 years, 3 months ago by Mircea Trofin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Pre-spill ranges that have a slot use. BUG= Committed: https://crrev.com/57ae3dbf94f919154de78d37d720877f4ec14756 Cr-Commit-Position: refs/heads/master@{#39634}

Patch Set 1 #

Patch Set 2 : [turbofan] Don't pre-spill ranges that don't even have a slot use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/compiler/register-allocator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-allocator.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Jarin
lgtm
4 years, 3 months ago (2016-09-22 06:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355373002/20001
4 years, 3 months ago (2016-09-22 15:15:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 15:42:41 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 15:43:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57ae3dbf94f919154de78d37d720877f4ec14756
Cr-Commit-Position: refs/heads/master@{#39634}

Powered by Google App Engine
This is Rietveld 408576698