Return 409 error when uploading build with same number again

go/src/infra/appengine/test-results/frontend/upload_test.go

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package frontend
 
 import (
         "bytes"
         "encoding/json"
         "infra/appengine/test-results/model"
@@ skipping 242 matching lines @@
                                 reader, err := tf.DataReader(ctx)
                                 So(err, ShouldBeNil)
                                 var updated model.AggregateResult
                                 So(json.NewDecoder(reader).Decode(&updated), ShouldBeNil)
 
                                 // TODO(nishanths): also check `updated` ShouldResemble `expected`.
                         })
                 })
         })
 }
+
+func TestUses409ResponseCodeForBuildNumberConflict(t *testing.T) {
+        t.Parallel()
+
+        Convey("Return HTTP response code 409 for build with same number", t, func() {
+                ctx := memory.Use(context.Background())
+                testFileIdx, err := datastore.FindAndParseIndexYAML(
+                        filepath.Join("testdata"))
+                if err != nil {
+                        panic(err)
+                }
+                datastore.GetTestable(ctx).AddIndexes(testFileIdx...)
+                datastore.GetTestable(ctx).CatchupIndexes()
+
+                ctx = SetUploadParams(ctx, &UploadParams{
+                        Master:   "foo",
+                        Builder:  "bar",
+                        TestType: "baz",
+                })
+                data, err := ioutil.ReadFile(
+                        filepath.Join("testdata", "full_results_0.json"))
+                data = bytes.TrimSpace(data)
+                So(err, ShouldBeNil)
+
+                So(updateFullResults(ctx, bytes.NewReader(data)), ShouldBeNil)
+
+                // Ensure that the file is saved in datastore. See http://crbug.com/648817.
+                datastore.GetTestable(ctx).CatchupIndexes()
+
+                err = updateFullResults(ctx, bytes.NewReader(data))
+                se, ok := err.(statusError)
+                So(ok, ShouldBeTrue)
+                So(se.code, ShouldEqual, 409)
+        })
+}