Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2355343003: SkDocument::close is changing to void (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SkDocument::close is changing to void Pending Skia CL is here: https://codereview.chromium.org/2354403002/ BUG= Committed: https://crrev.com/e35e053f2ea486e92ea1fa6df28af83cae0a82fc Cr-Commit-Position: refs/heads/master@{#420382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M printing/pdf_metafile_skia.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
reed1
ptal
4 years, 3 months ago (2016-09-22 15:34:14 UTC) #7
f(malita)
lgtm
4 years, 3 months ago (2016-09-22 15:50:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355343003/1
4 years, 3 months ago (2016-09-22 16:02:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/264774)
4 years, 3 months ago (2016-09-22 16:10:43 UTC) #12
reed1
need OWNER from printing/
4 years, 3 months ago (2016-09-22 16:12:20 UTC) #14
dpapad
Forwarding to thestig@.
4 years, 3 months ago (2016-09-22 16:43:37 UTC) #15
dpapad
4 years, 3 months ago (2016-09-22 16:43:58 UTC) #17
reed1
4 years, 3 months ago (2016-09-22 16:51:56 UTC) #18
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-22 17:03:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355343003/1
4 years, 3 months ago (2016-09-22 17:23:52 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 17:30:55 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 17:36:04 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e35e053f2ea486e92ea1fa6df28af83cae0a82fc
Cr-Commit-Position: refs/heads/master@{#420382}

Powered by Google App Engine
This is Rietveld 408576698