Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 2355303002: Replace Manual test with a LayoutTest (Closed)

Created:
4 years, 3 months ago by nainar
Modified:
4 years, 3 months ago
Reviewers:
sashab
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, mstensho (USE GERRIT), rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace Manual test with a LayoutTest BUG=634565 Committed: https://crrev.com/273e2988ee4e07931eb3c8f61068826c138e645e Cr-Commit-Position: refs/heads/master@{#420286}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -30 lines) Patch
A third_party/WebKit/LayoutTests/printing/printing-resize-starts-transition.html View 1 chunk +40 lines, -0 lines 1 comment Download
D third_party/WebKit/ManualTests/printing-resize-starts-transition.html View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nainar
PTAL? Thanks! It fails on Stable passes on trunk. Replacing a ManualTest I added with ...
4 years, 3 months ago (2016-09-21 14:46:17 UTC) #4
sashab
https://codereview.chromium.org/2355303002/diff/1/third_party/WebKit/LayoutTests/printing/printing-resize-starts-transition.html File third_party/WebKit/LayoutTests/printing/printing-resize-starts-transition.html (right): https://codereview.chromium.org/2355303002/diff/1/third_party/WebKit/LayoutTests/printing/printing-resize-starts-transition.html#newcode24 third_party/WebKit/LayoutTests/printing/printing-resize-starts-transition.html:24: <div id="target"> Not needed, you can delete all this ...
4 years, 3 months ago (2016-09-22 00:20:24 UTC) #5
sashab
lgtm after you fix that :)
4 years, 3 months ago (2016-09-22 00:20:38 UTC) #6
nainar
With printing tests that I write I feel more comfortable leaving some instruction on manual ...
4 years, 3 months ago (2016-09-22 08:07:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355303002/1
4 years, 3 months ago (2016-09-22 08:07:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 08:59:47 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/273e2988ee4e07931eb3c8f61068826c138e645e Cr-Commit-Position: refs/heads/master@{#420286}
4 years, 3 months ago (2016-09-22 09:01:59 UTC) #12
sashab
4 years, 3 months ago (2016-09-23 00:17:52 UTC) #13
Message was sent while issue was closed.
Yup that sgtm.

Powered by Google App Engine
This is Rietveld 408576698