Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2355203002: Rename Topic's Name method to String. (Closed)

Created:
4 years, 3 months ago by dsansome
Modified:
4 years, 2 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M logdog/client/butler/output/pubsub/pubsubOutput.go View 2 chunks +3 lines, -3 lines 0 comments Download
M logdog/client/butler/output/pubsub/pubsubOutput_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
dsansome
4 years, 3 months ago (2016-09-21 04:16:07 UTC) #2
dnj
lgtm
4 years, 3 months ago (2016-09-21 15:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355203002/1
4 years, 3 months ago (2016-09-21 15:59:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Linux Precise 32 Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31664a7893eaeb10) ...
4 years, 3 months ago (2016-09-21 16:02:01 UTC) #7
dnj
On 2016/09/21 16:02:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-21 17:45:23 UTC) #8
dsansome
On 2016/09/21 17:45:23, dnj wrote: > On 2016/09/21 16:02:01, commit-bot: I haz the power wrote: ...
4 years, 2 months ago (2016-09-26 07:45:42 UTC) #9
dsansome
On 2016/09/26 07:45:42, dsansome wrote: > On 2016/09/21 17:45:23, dnj wrote: > > On 2016/09/21 ...
4 years, 2 months ago (2016-09-26 08:06:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355203002/1
4 years, 2 months ago (2016-09-26 08:30:54 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 08:39:10 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/45c0daa70b20e580b7b6c50ec5a61a00b6b5a3ca

Powered by Google App Engine
This is Rietveld 408576698