Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: chrome/browser/extensions/extension_unload_browsertest.cc

Issue 2355183002: [Extensions] Don't run unload listeners when an extension is removed (Closed)
Patch Set: Remove terminated extensions reference Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/fast_unload_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_unload_browsertest.cc
diff --git a/chrome/browser/extensions/extension_unload_browsertest.cc b/chrome/browser/extensions/extension_unload_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ea2a94ce8560cfbc2dc2a41be161b98ec3a1ca0d
--- /dev/null
+++ b/chrome/browser/extensions/extension_unload_browsertest.cc
@@ -0,0 +1,40 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_browsertest.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "ui/base/window_open_disposition.h"
+
+namespace extensions {
+
+using ExtensionUnloadBrowserTest = ExtensionBrowserTest;
+
+IN_PROC_BROWSER_TEST_F(ExtensionUnloadBrowserTest, TestUnload) {
+ // Load an extension that installs unload and beforeunload listeners.
+ const Extension* extension =
+ LoadExtension(test_data_dir_.AppendASCII("unload_listener"));
+ ASSERT_TRUE(extension);
+ std::string id = extension->id();
+ ASSERT_EQ(1, browser()->tab_strip_model()->count());
+ GURL initial_tab_url =
+ browser()->tab_strip_model()->GetWebContentsAt(0)->GetLastCommittedURL();
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), extension->GetResourceURL("page.html"),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+ EXPECT_EQ(2, browser()->tab_strip_model()->count());
+ extension_service()->UnloadExtension(id,
+ UnloadedExtensionInfo::REASON_DISABLE);
+ // There should only be one remaining web contents - the initial one.
+ ASSERT_EQ(1, browser()->tab_strip_model()->count());
+ EXPECT_EQ(
+ initial_tab_url,
+ browser()->tab_strip_model()->GetWebContentsAt(0)->GetLastCommittedURL());
+}
+
+// TODO(devlin): Investigate what to do for embedded iframes.
+
+} // namespace extensions
« no previous file with comments | « no previous file | chrome/browser/ui/fast_unload_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698