[Extensions] Don't run unload listeners when an extension is removed

chrome/browser/ui/fast_unload_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/fast_unload_controller.h"
 
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/tabs/tab_strip_model_delegate.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
+#include "extensions/browser/extension_registry.h"
+#include "extensions/common/constants.h"
 
 namespace chrome {
 
-
 ////////////////////////////////////////////////////////////////////////////////
 // DetachedWebContentsDelegate will delete web contents when they close.
 class FastUnloadController::DetachedWebContentsDelegate
     : public content::WebContentsDelegate {
  public:
   DetachedWebContentsDelegate() { }
   ~DetachedWebContentsDelegate() override {}
 
  private:
   // WebContentsDelegate implementation.
@@ skipping 36 matching lines @@
 
 bool FastUnloadController::ShouldRunUnloadEventsHelper(
     content::WebContents* contents) {
   // If |contents| is being inspected, devtools needs to intercept beforeunload
   // events.
   return DevToolsWindow::GetInstanceForInspectedWebContents(contents) != NULL;
 }
 
 bool FastUnloadController::RunUnloadEventsHelper(
     content::WebContents* contents) {
+  GURL url = contents->GetLastCommittedURL();

[Charlie Reis, 2016/09/21 18:29:33]

Let's add a comment, like: Don't run unload for extensions that have been
disabled or uninstalled, because they would be killed if they made network
requests.

[Devlin, 2016/09/22 00:35:21]

Done.

+  if (url.SchemeIs(extensions::kExtensionScheme) &&
+      !extensions::ExtensionRegistry::Get(browser_->profile())

[Charlie Reis, 2016/09/21 18:29:33]

You would know better than I do, but does this need a if
defined(ENABLE_EXTENSIONS)?  I'm not sure which classes do and don't. 
(chrome/browser/browser.cc doesn't, but chrome/browser/site_details.cc does, for
example.)

[Devlin, 2016/09/22 00:35:21]

Probably should, yes.  Added.  An OWNER here can double-check.

+           ->enabled_extensions()
+           .GetExtensionOrAppByURL(url)) {
+    return false;
+  }
+
   // Special case for when we quit an application. The Devtools window can
   // close if it's beforeunload event has already fired which will happen due
   // to the interception of it's content's beforeunload.
   if (browser_->is_devtools() &&
       DevToolsWindow::HasFiredBeforeUnloadEventForDevToolsBrowser(browser_))
     return false;
 
   // If there's a devtools window attached to |contents|,
   // we would like devtools to call its own beforeunload handlers first,
   // and then call beforeunload handlers for |contents|.
@@ skipping 377 matching lines @@
   }
 }
 
 void FastUnloadController::PostTaskForProcessPendingTabs() {
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(&FastUnloadController::ProcessPendingTabs,
                             weak_factory_.GetWeakPtr()));
 }
 
 }  // namespace chrome