[Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator watchdog timeout in…

[Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator watchdog timeout in UMA and event log.

BUG=624452
Committed: https://crrev.com/101a2419fd6bbf68f63c0ee97ecf60a5b5588127
Cr-Commit-Position: refs/heads/master@{#420153}

[dougarnett, 2016-09-21 00:18:07]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:18:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2016-09-21 00:19:35]

dougarnett@chromium.org changed reviewers:
+ petewil@chromium.org

[Pete Williamson, 2016-09-21 00:29:10]

https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_coordinator.cc (right):

https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.cc:190:
StopPrerendering(Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED);
This is really the user deciding to cancel, not the request coordinator.  Should
we have a different status for user cancelling?

[commit-bot: I haz the power, 2016-09-21 02:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:00:59]

Dry run: This issue passed the CQ dry run.

[dougarnett, 2016-09-21 15:58:57]

https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_coordinator.cc (right):

https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_coordinator.cc:190:
StopPrerendering(Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED);
On 2016/09/21 00:29:09, Pete Williamson wrote:
> This is really the user deciding to cancel, not the request coordinator. 
Should
> we have a different status for user cancelling?

We don't actually know at this point whether this is due to a user Pause or user
Remove (the two current callers). We could consider plumbing finer grained
status into this method. But I'm not sure yet we want to expand too much into RC
land causes. This Offliner::RequestStatus was originally about the offline
processing disposition (the notifier status is more about the request
disposition). It does makes sense to me to split out the timeouts though as this
means the offlining took too long vs. a cancel due to some other activity
outside the scope of offlining. I wonder if separately we want UMA for Pause and
Remove and other user driven actions (they would correlate to these cancels for
the subset of cases where the request was active).

[Pete Williamson, 2016-09-21 16:34:52]

lgtm

[dougarnett, 2016-09-21 16:50:28]

dougarnett@chromium.org changed reviewers:
+ holte@chromium.org

[dougarnett, 2016-09-21 16:50:28]

Steven, can you review histograms.xml change please?

[Steven Holte, 2016-09-21 20:12:21]

histograms.xml lgtm

[dougarnett, 2016-09-21 20:29:54]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:30:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:36:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 20:38:59]

Description was changed from

==========
[Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator
watchdog timeout in UMA and event log.

BUG=624452
==========

to

==========
[Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator
watchdog timeout in UMA and event log.

BUG=624452

Committed: https://crrev.com/101a2419fd6bbf68f63c0ee97ecf60a5b5588127
Cr-Commit-Position: refs/heads/master@{#420153}
==========

[commit-bot: I haz the power, 2016-09-21 20:39:00]

Patchset 1 (id:??) landed as
https://crrev.com/101a2419fd6bbf68f63c0ee97ecf60a5b5588127
Cr-Commit-Position: refs/heads/master@{#420153}