Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2355163002: [Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator watchdog timeout in… (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Breaks out new TIMED_OUT Offliner status for RequestCoordinator watchdog timeout in UMA and event log. BUG=624452 Committed: https://crrev.com/101a2419fd6bbf68f63c0ee97ecf60a5b5588127 Cr-Commit-Position: refs/heads/master@{#420153}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M components/offline_pages/background/offliner.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.h View 1 chunk +5 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 4 chunks +18 lines, -7 lines 2 comments Download
M components/offline_pages/background/request_coordinator_event_logger.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
dougarnett
4 years, 3 months ago (2016-09-21 00:19:35 UTC) #4
Pete Williamson
https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/background/request_coordinator.cc#newcode190 components/offline_pages/background/request_coordinator.cc:190: StopPrerendering(Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED); This is really the user deciding to cancel, ...
4 years, 3 months ago (2016-09-21 00:29:10 UTC) #5
dougarnett
https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2355163002/diff/1/components/offline_pages/background/request_coordinator.cc#newcode190 components/offline_pages/background/request_coordinator.cc:190: StopPrerendering(Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED); On 2016/09/21 00:29:09, Pete Williamson wrote: > This ...
4 years, 3 months ago (2016-09-21 15:58:57 UTC) #8
Pete Williamson
lgtm
4 years, 3 months ago (2016-09-21 16:34:52 UTC) #9
dougarnett
Steven, can you review histograms.xml change please?
4 years, 3 months ago (2016-09-21 16:50:28 UTC) #11
Steven Holte
histograms.xml lgtm
4 years, 3 months ago (2016-09-21 20:12:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355163002/1
4 years, 3 months ago (2016-09-21 20:30:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 20:36:06 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:39:00 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/101a2419fd6bbf68f63c0ee97ecf60a5b5588127
Cr-Commit-Position: refs/heads/master@{#420153}

Powered by Google App Engine
This is Rietveld 408576698