Disallowed PassRefPtr copies across threads.

Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode CrossThreadCopier<PassRefPtr>::copy taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp?l=215

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/be469c01f9657a1598ba00423f26279e2c24f0c9
Cr-Commit-Position: refs/heads/master@{#421127}

[Bugs Nash, 2016-09-21 00:07:40]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy

BUG=640449
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-21 00:11:39]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy,
e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-21 00:20:39]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy,
e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-21 00:21:01]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-21 00:21:20]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:21:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 03:00:16]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2016-09-21 23:13:42]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[Bugs Nash, 2016-09-21 23:13:47]

bugsnash@chromium.org changed reviewers:
+ yutak@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:14:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2016-09-21 23:15:18]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode copy method for CrossThreadCopier<PassRefPtr> taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode CrossThreadCopier<PassRefPtr>::copy taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-21 23:15:42]

Not sure if this is the best solution, ptal

[commit-bot: I haz the power, 2016-09-22 01:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 01:19:41]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-09-23 07:33:35]

This looks okay, LGTM w/ a nit.

https://codereview.chromium.org/2355153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/CrossThreadCopier.h (right):

https://codereview.chromium.org/2355153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/CrossThreadCopier.h:94: struct
CrossThreadCopier<PassRefPtr<T>> : public
CrossThreadCopierPassThrough<PassRefPtr<T>> {
You probably should remove this inheritance and define Type yourself,
since this isn't really the usual "pass through" copy.

[Bugs Nash, 2016-09-27 00:06:42]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 00:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2016-09-27 00:12:49]

On 2016/09/23 at 07:33:35, yutak wrote:
> This looks okay, LGTM w/ a nit.
> 
>
https://codereview.chromium.org/2355153002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/CrossThreadCopier.h (right):
> 
>
https://codereview.chromium.org/2355153002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/CrossThreadCopier.h:94: struct
CrossThreadCopier<PassRefPtr<T>> : public
CrossThreadCopierPassThrough<PassRefPtr<T>> {
> You probably should remove this inheritance and define Type yourself,
> since this isn't really the usual "pass through" copy.

Could you please take a look at the change I've made as I'm not sure if this is
what you were thinking. Have removed the inheritance and defined Type as you
suggested. Also had to change the static_assert as the Type has changed. Can
alternatively change the typedef to:
typedef PassRefPtr<T> Type;

[commit-bot: I haz the power, 2016-09-27 01:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 01:46:04]

Dry run: This issue passed the CQ dry run.

[Yuta Kitamura, 2016-09-27 01:59:28]

https://codereview.chromium.org/2355153002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/CrossThreadCopier.cpp (right):

https://codereview.chromium.org/2355153002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/CrossThreadCopier.cpp:79:
CopierThreadSafeRefCountedTest,
You don't have to change this.

https://codereview.chromium.org/2355153002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/CrossThreadCopier.h (right):

https://codereview.chromium.org/2355153002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/CrossThreadCopier.h:96: typedef T Type;
Type should be PassRefPtr<T>, not T. In the original code,
the type parameter of CrossThreadCopierPassThrough was
PassRefPtr<T>, thus Type was PassRefPtr<T>.

(optional: you can also use "using Type = PassRefPtr<T>;"
syntax.)

[Yuta Kitamura, 2016-09-27 02:00:36]

LGTM if my prior comments are addressed.

[Bugs Nash, 2016-09-27 04:53:42]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2016-09-27 04:53:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/2355153002/#ps60001
(title: "Changed typedef to PassRefPtr<T>")

[commit-bot: I haz the power, 2016-09-27 04:54:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:03:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-09-27 05:07:31]

owner LGTM

[Bugs Nash, 2016-09-27 05:28:07]

On 2016/09/27 at 05:07:31, haraken wrote:
> owner LGTM

of course, thanks Kentaro!

[Bugs Nash, 2016-09-27 05:28:10]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:28:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 06:21:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-27 06:23:02]

Description was changed from

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode CrossThreadCopier<PassRefPtr>::copy taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Disallowed PassRefPtr copies across threads.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

Overrode CrossThreadCopier<PassRefPtr>::copy taking an
rvalue, disallowing lvalues of PassRefPtr to be passed in.

Wrapped return value of CrossThreadCopier<PassRefPtr<T>>::copy in
std::move to ensure an rvalue is returned. This is necessary to
prevent PassRefPtr copies where a PassRefPtr object is constructed
inside the call to CrossThreadCopier::copy, e.g.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaud...

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/be469c01f9657a1598ba00423f26279e2c24f0c9
Cr-Commit-Position: refs/heads/master@{#421127}
==========

[commit-bot: I haz the power, 2016-09-27 06:23:04]

Patchset 4 (id:??) landed as
https://crrev.com/be469c01f9657a1598ba00423f26279e2c24f0c9
Cr-Commit-Position: refs/heads/master@{#421127}