Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2355143002: Merge M54: "Allow suspension prior to reaching kHaveFutureData." (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge M54: "Allow suspension prior to reaching kHaveFutureData." This change rolls in a few changes: - Removes DelegateState::PAUSED_BUT_NOT_IDLE state. - Removes all blocks against suspending prior to kHaveFutureData. - If suspended, triggers resume when prior to have kHaveFutureData if the didLoadingProgress() timer reports true. - Always notifies the delegate of DelegateState::GONE; this ensures the idle timer is always restarted if we didn't quite get enough data to reach kHaveFutureData. - Fixes pause timer to handle newly supported background video; which doesn't set a state of DelegateState::GONE BUG=612909, 643383 TEST=new and updated unittests. Review-Url: https://codereview.chromium.org/2289543005 Cr-Commit-Position: refs/heads/master@{#416431} (cherry picked from commit e7120dcf27938c9604ec03b3b574e1b4b3bf6c28) Committed: https://chromium.googlesource.com/chromium/src/+/4c621e70b04fd5ae89a95d58c10d040c57af9f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -65 lines) Patch
M content/renderer/media/renderer_webmediaplayer_delegate.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 7 chunks +41 lines, -47 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 22 chunks +82 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 3 months ago (2016-09-20 23:56:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c621e70b04fd5ae89a95d58c10d040c57af9f12.

Powered by Google App Engine
This is Rietveld 408576698