Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2355113002: Android Studio: Map test_apk targets to their correct build_config (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Studio: Map test_apk targets to their correct build_config This just adds a shortcut for test_apk --> test_apk__apk. We should still look at adding "better" instrumentation test support later. This also changes the default target to chrome_public_apk_test BUG=620034 TBR=jbudorick Committed: https://crrev.com/8daac2fedb75dc72c918817171f8eb34395ad3aa Cr-Commit-Position: refs/heads/master@{#420223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/android/gradle/generate_gradle.py View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
agrieve
On 2016/09/20 20:37:59, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
4 years, 3 months ago (2016-09-20 20:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355113002/1
4 years, 3 months ago (2016-09-22 00:58:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 01:04:41 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8daac2fedb75dc72c918817171f8eb34395ad3aa Cr-Commit-Position: refs/heads/master@{#420223}
4 years, 3 months ago (2016-09-22 01:10:14 UTC) #14
jbudorick
4 years, 3 months ago (2016-09-22 02:24:48 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698