Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 23551005: Revert 219709 "Remove the Extensions URLRequestContext." (Closed)

Created:
7 years, 3 months ago by earthdok
Modified:
5 years ago
Reviewers:
awong
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 219709 "Remove the Extensions URLRequestContext." Reverted due to crashes under memory tools. BUG=280138 > Remove the Extensions URLRequestContext. > > Though chrome-extension: scheme URLs support cookies, they do not share > a namespace with http: and https:. In particular, chrome-extension://a and > http://a should not have the same set of cookies. > > To enforce this, previously the code created a completely separate > URLRequestContext for servicing chrome-extension: schemes. However, > the code really only used this object as a method for conveying the > correct cookie jar from Profile creation to a few spots where cookies > were accessed; the rest of the URLRequestContext functionality was unused. > > This CL removes the Extensions URLRequestContext code and replaces it > with APIs that directly expose the needed net::CookieStore. > > Lastly, CookieMonster::EnableFileScheme() is removed and > CookieMonster::Delegate is renamed CookieMonsterDelegate. > > EnableFileScheme is an inherently racy API because > CookieMonsters are creatable on all threads and this > function sets an unprotected global flag. CookieMonsterDelegate > is preferable to the nested interface because it can now be > forward declared. > > TBRing darin and sky to cover the rest of the mechanical unittest changes. > > TBR=darin,sky > BUG=158386, 159193, 57884 > > Review URL: https://chromiumcodereview.appspot.com/12546016 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1150 lines, -1302 lines) Patch
M trunk/src/android_webview/browser/aw_browser_context.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/android_webview/browser/aw_browser_context.cc View 3 chunks +9 lines, -23 lines 0 comments Download
M trunk/src/android_webview/browser/net/aw_url_request_context_getter.h View 2 chunks +3 lines, -1 line 0 comments Download
M trunk/src/android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/android_webview/native/aw_quota_manager_bridge_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/apps/shell_window_geometry_cache_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/autocomplete/bookmark_provider_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/background/background_contents_service_unittest.cc View 5 chunks +75 lines, -78 lines 0 comments Download
M trunk/src/chrome/browser/background/background_mode_manager_unittest.cc View 1 chunk +5 lines, -26 lines 0 comments Download
M trunk/src/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc View 2 chunks +10 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 3 chunks +4 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 4 chunks +12 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_request_limiter_unittest.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/cookies/cookies_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 8 chunks +13 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 6 chunks +10 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/data_deleter.cc View 1 chunk +29 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/error_console/error_console_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_process_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_warning_badge_service_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_warning_service_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/menu_manager_unittest.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/history/shortcuts_backend_unittest.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/history/shortcuts_database_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/history/thumbnail_database_unittest.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/invalidation/ticl_invalidation_service_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/io_thread.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/managed_mode/managed_user_sync_service_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_cookie_notification_details.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/net/chrome_url_request_context.h View 2 chunks +10 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_url_request_context.cc View 3 chunks +32 lines, -0 lines 0 comments Download
D trunk/src/chrome/browser/net/cookie_store_util.h View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/src/chrome/browser/net/cookie_store_util.cc View 1 chunk +0 lines, -141 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/password_form_manager_unittest.cc View 7 chunks +12 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc View 6 chunks +21 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/prefs/pref_model_associator_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/printing/print_dialog_cloud_unittest.cc View 8 chunks +27 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/profile_resetter/profile_resetter_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/profiles/avatar_menu_model_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_impl.h View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_impl.cc View 4 chunks +5 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.h View 4 chunks +7 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/off_the_record_profile_io_data.cc View 4 chunks +66 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl.h View 4 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl.cc View 7 chunks +25 lines, -39 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl_io_data.h View 4 chunks +11 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/profiles/profile_impl_io_data.cc View 11 chunks +131 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.h View 7 chunks +12 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.cc View 8 chunks +75 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_loader_unittest.cc View 5 chunks +6 lines, -37 lines 0 comments Download
M trunk/src/chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/signin/signin_manager_unittest.cc View 4 chunks +10 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/spellchecker/feedback_sender_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/sync_global_error_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/thumbnails/thumbnail_service_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/autofill/account_chooser_model_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/bookmarks/bookmark_ui_utils_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/gtk_theme_service_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/omnibox/omnibox_controller_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/omnibox/omnibox_edit_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/sync/sync_promo_ui_unittest.cc View 4 chunks +18 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/suggestions_combiner_unittest.cc View 2 chunks +22 lines, -12 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/chrome_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/chrome_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/testing_profile.h View 3 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/base/testing_profile.cc View 6 chunks +45 lines, -14 lines 0 comments Download
M trunk/src/components/autofill/content/browser/wallet/wallet_signin_helper_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/content/browser/appcache/chrome_appcache_service_unittest.cc View 8 chunks +52 lines, -15 lines 0 comments Download
M trunk/src/content/browser/browser_context.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/content/browser/fileapi/fileapi_message_filter_unittest.cc View 12 chunks +17 lines, -11 lines 0 comments Download
M trunk/src/content/browser/loader/resource_dispatcher_host_unittest.cc View 11 chunks +13 lines, -25 lines 0 comments Download
M trunk/src/content/browser/loader/resource_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/content/browser/net/cookie_store_map.h View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/content/browser/net/cookie_store_map.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M trunk/src/content/browser/net/sqlite_persistent_cookie_store.cc View 3 chunks +8 lines, -42 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_message_filter.h View 4 chunks +6 lines, -8 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_message_filter.cc View 10 chunks +32 lines, -41 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl.h View 6 chunks +8 lines, -14 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl.cc View 14 chunks +53 lines, -28 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl_map.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl_map.cc View 7 chunks +4 lines, -86 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/public/browser/browser_context.h View 3 chunks +3 lines, -24 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.h View 3 chunks +8 lines, -2 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/src/content/public/browser/cookie_store_factory.h View 1 chunk +8 lines, -32 lines 0 comments Download
M trunk/src/content/public/browser/storage_partition.h View 4 chunks +9 lines, -6 lines 0 comments Download
M trunk/src/content/public/common/content_constants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/public/common/content_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/public/test/mock_resource_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/public/test/mock_resource_context.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/content/public/test/test_browser_context.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/shell/browser/shell_browser_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell_url_request_context_getter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/content/test/test_content_browser_client.h View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/content/test/test_content_browser_client.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster.h View 10 chunks +17 lines, -17 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster.cc View 6 chunks +30 lines, -23 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster_store_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/cookies/cookie_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/webkit/support/test_webkit_platform_support.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
earthdok
7 years, 3 months ago (2013-08-27 14:20:49 UTC) #1
earthdok
7 years, 3 months ago (2013-08-27 14:39:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r219787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698