Do not flush SequencedWorkerPools in browser tests.

Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400
Committed: https://crrev.com/0881867ce08db7368ca9f6ea10aa230dc2849227
Cr-Commit-Position: refs/heads/master@{#420366}

[fdoray, 2016-09-20 20:33:10]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 21:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:40:38]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-09-21 15:36:44]

Description was changed from

==========
Do not flush SequencedWorkerPools in browser tests.

BUG=
==========

to

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

BUG=622400
==========

[fdoray, 2016-09-21 16:51:52]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org, sky@chromium.org

[fdoray, 2016-09-21 16:51:52]

gab@ and robliao@ for initial review.

sky@: You can chime in now. Otherwise, I'll ask you later for an owner approval.

Thanks!

[gab, 2016-09-21 17:08:12]

lgtm

[robliao, 2016-09-21 17:14:31]

lgtm

[fdoray, 2016-09-21 17:35:33]

fdoray@chromium.org changed reviewers:
+ eugenebut@chromium.org

[fdoray, 2016-09-21 17:35:34]

sky@: Please review changes in content/public/test/content_test_suite_base.cc

eugenebut@: Please review changes in ios/web/test/web_test_suite.mm

[fdoray, 2016-09-21 17:36:26]

Description was changed from

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

BUG=622400
==========

to

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400
==========

[Eugene But (OOO till 7-30), 2016-09-21 20:36:42]

ios lgtm. Do you know if this works with Chrome for iOS downstream repo? CCing
iOS sheriff, to watch the tree

[sky, 2016-09-21 22:01:45]

LGTM

[fdoray, 2016-09-22 14:15:18]

On 2016/09/21 20:36:42, Eugene But wrote:
> ios lgtm. Do you know if this works with Chrome for iOS downstream repo? CCing
> iOS sheriff, to watch the tree

Passed smoke and smoke-x64 iOS tests.

[fdoray, 2016-09-22 14:16:33]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-22 14:16:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-22 14:27:24]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2016-09-22 14:28:40]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 14:28:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-22 14:30:38]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2016-09-22 16:15:08]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:15:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 16:22:45]

Description was changed from

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400
==========

to

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400
==========

[commit-bot: I haz the power, 2016-09-22 16:22:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-22 16:24:46]

Description was changed from

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400
==========

to

==========
Do not flush SequencedWorkerPools in browser tests.

Before this CL, the blocking pool and the simple cache's pool were
flushed at the end of each browser test. That means that every task
posted to these pools ran, regardless of their shutdown behavior.
This flush was introduced by https://codereview.chromium.org/11649032
to prevent leaks between tests (see https://crbug.com/168415).

This flush is not required for browser tests since they each run in
their own process.

Note that in production, BrowserThreads are joined before the
blocking pool. Before this CL, the blocking pool was flushed before
BrowserThreads were joined. With this CL, the behavior of browser
threads is closer to production.

Why is this important? There is no way to flush TaskScheduler and
we would prefer not to implement it if it is not required.

BUG=622400

Committed: https://crrev.com/0881867ce08db7368ca9f6ea10aa230dc2849227
Cr-Commit-Position: refs/heads/master@{#420366}
==========

[commit-bot: I haz the power, 2016-09-22 16:24:47]

Patchset 1 (id:??) landed as
https://crrev.com/0881867ce08db7368ca9f6ea10aa230dc2849227
Cr-Commit-Position: refs/heads/master@{#420366}