Make CPDF_Array not do indirect object creation.

fpdfsdk/fpdfsave.cpp

Index: fpdfsdk/fpdfsave.cpp
diff --git a/fpdfsdk/fpdfsave.cpp b/fpdfsdk/fpdfsave.cpp
index 307163d1afabaa813adf2d0c2616a75a975f5c23..d306778f0ce5a2e87f1253a318ce801f38e8fe4d 100644
--- a/fpdfsdk/fpdfsave.cpp
+++ b/fpdfsdk/fpdfsave.cpp
@@ -188,7 +188,7 @@ bool SaveXFADocumentData(CPDFXFA_Document* pDocument,
         pPDFDocument->AddIndirectObject(pData);
         iLast = pArray->GetCount() - 2;
         pArray->InsertAt(iLast, new CPDF_String("datasets", FALSE));
-        pArray->InsertAt(iLast + 1, pData, pPDFDocument);
+        pArray->InsertAt(iLast + 1, pData);

[dsinclair, 2016/09/20 19:32:18]

Does this need to be wrapped in a Reference? We did an AddIndirectObject(pData)
on 188.

[Tom Sepez, 2016/09/20 20:07:22]

Good catch.  I missed this one. and the one below it.

       }
       fileList->push_back(std::move(pDsfileWrite));
     }
@@ -209,7 +209,7 @@ bool SaveXFADocumentData(CPDFXFA_Document* pDocument,
         pPDFDocument->AddIndirectObject(pData);
         iLast = pArray->GetCount() - 2;
         pArray->InsertAt(iLast, new CPDF_String("form", FALSE));
-        pArray->InsertAt(iLast + 1, pData, pPDFDocument);
+        pArray->InsertAt(iLast + 1, pData);

[dsinclair, 2016/09/20 19:32:18]

ditto

[Tom Sepez, 2016/09/20 20:07:22]

Done.

       }
       fileList->push_back(std::move(pfileWrite));
     }