Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 235503010: Web Animations: Fix effect change calculation when player is cancelled but not held (Closed)

Created:
6 years, 8 months ago by dstockwell
Modified:
6 years, 8 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations: Fix effect change calculation when player is cancelled but not held Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171439

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M Source/core/animation/AnimationPlayer.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dstockwell
6 years, 8 months ago (2014-04-14 06:17:10 UTC) #1
Timothy Loh
lgtm
6 years, 8 months ago (2014-04-14 06:30:52 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-14 06:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/235503010/20001
6 years, 8 months ago (2014-04-14 06:31:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 07:08:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-14 07:08:51 UTC) #6
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 8 months ago (2014-04-14 07:44:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/235503010/20001
6 years, 8 months ago (2014-04-14 07:44:19 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 08:14:23 UTC) #9
Message was sent while issue was closed. 
Change committed as 171439

Powered by Google App Engine
This is Rietveld 408576698