Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2355023002: Preserving Content-Type header from http request in OpenURL path. (Closed)
Patch Set: Filtering headers in PrerenderManager instead. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index addc6d379be402b45619a5706b35118d124fd046..b5db7650935f9fbc151e71cf09802d77a4f519fe 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3071,7 +3071,8 @@ void RenderFrameImpl::loadURLExternally(const blink::WebURLRequest& request,
suggested_name));
} else {
OpenURL(request.url(), IsHttpPost(request),
- GetRequestBodyForWebURLRequest(request), referrer, policy,
+ GetRequestBodyForWebURLRequest(request),
+ GetWebURLRequestHeaders(request), referrer, policy,
should_replace_current_entry, false);
}
}
@@ -4984,7 +4985,8 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
render_view_->renderer_preferences_
.browser_handles_all_top_level_requests) {
OpenURL(url, IsHttpPost(info.urlRequest),
- GetRequestBodyForWebURLRequest(info.urlRequest), referrer,
+ GetRequestBodyForWebURLRequest(info.urlRequest),
+ GetWebURLRequestHeaders(info.urlRequest), referrer,
info.defaultPolicy, info.replacesCurrentHistoryItem, false);
return blink::WebNavigationPolicyIgnore; // Suppress the load here.
}
@@ -5004,7 +5006,8 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
// JavaScript on the page is trying to interrupt the history navigation.
if (!info.isClientRedirect) {
OpenURL(url, IsHttpPost(info.urlRequest),
- GetRequestBodyForWebURLRequest(info.urlRequest), referrer,
+ GetRequestBodyForWebURLRequest(info.urlRequest),
+ GetWebURLRequestHeaders(info.urlRequest), referrer,
info.defaultPolicy, info.replacesCurrentHistoryItem, true);
// Suppress the load in Blink but mark the frame as loading.
return blink::WebNavigationPolicyHandledByClient;
@@ -5065,6 +5068,7 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
if (should_fork) {
OpenURL(url, IsHttpPost(info.urlRequest),
GetRequestBodyForWebURLRequest(info.urlRequest),
+ GetWebURLRequestHeaders(info.urlRequest),
send_referrer ? referrer : Referrer(), info.defaultPolicy,
info.replacesCurrentHistoryItem, false);
return blink::WebNavigationPolicyIgnore; // Suppress the load here.
@@ -5106,7 +5110,8 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(
if (is_fork) {
// Open the URL via the browser, not via WebKit.
OpenURL(url, IsHttpPost(info.urlRequest),
- GetRequestBodyForWebURLRequest(info.urlRequest), Referrer(),
+ GetRequestBodyForWebURLRequest(info.urlRequest),
+ GetWebURLRequestHeaders(info.urlRequest), Referrer(),
info.defaultPolicy, info.replacesCurrentHistoryItem, false);
return blink::WebNavigationPolicyIgnore;
}
@@ -5428,6 +5433,7 @@ void RenderFrameImpl::OpenURL(
const GURL& url,
bool uses_post,
const scoped_refptr<ResourceRequestBodyImpl>& resource_request_body,
+ const std::string& extra_headers,
const Referrer& referrer,
WebNavigationPolicy policy,
bool should_replace_current_entry,
@@ -5436,6 +5442,7 @@ void RenderFrameImpl::OpenURL(
params.url = url;
params.uses_post = uses_post;
params.resource_request_body = resource_request_body;
+ params.extra_headers = extra_headers;
params.referrer = referrer;
params.disposition = RenderViewImpl::NavigationPolicyToDisposition(policy);
@@ -5932,8 +5939,7 @@ void RenderFrameImpl::BeginNavigation(const NavigationPolicyInfo& info) {
REQUEST_CONTEXT_FRAME_TYPE_NESTED);
Send(new FrameHostMsg_BeginNavigation(
- routing_id_,
- MakeCommonNavigationParams(info),
+ routing_id_, MakeCommonNavigationParams(info),
BeginNavigationParams(
GetWebURLRequestHeaders(info.urlRequest),
GetLoadFlagsForWebURLRequest(info.urlRequest),

Powered by Google App Engine
This is Rietveld 408576698