Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2355003002: GN: compiler_prefix -> cc_wrapper (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: compiler_prefix -> cc_wrapper I was a bit mixed up thinking Chrome called this feature compiler_prefix. They actually call it cc_wrapper. So let's switch to their name before we get too used to this. No bots are affected. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355003002 DOCS_PREVIEW= https://skia.org/?cl=2355003002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/60b7ab7a8efa0140d75c74a249e6648cc69aeee5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M gn/BUILD.gn View 3 chunks +11 lines, -12 lines 0 comments Download
M site/user/quick/gn.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-20 17:12:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2355003002/1
4 years, 3 months ago (2016-09-20 17:12:24 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-20 17:12:26 UTC) #6
jcgregorio
lgtm
4 years, 3 months ago (2016-09-20 17:16:58 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 19:09:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60b7ab7a8efa0140d75c74a249e6648cc69aeee5

Powered by Google App Engine
This is Rietveld 408576698