third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js - Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain. (Closed)

Patch Set: review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

index ed81dfd7ffb7b961a218ca3b41597a52d321c3ca..fd5b036a3278890876a5603191bb4f53605fd3df 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

@@ -224,8 +224,10 @@ WebInspector.TargetManager.prototype = {

target.tracingManager = new WebInspector.TracingManager(target);

- if (target.hasBrowserCapability())

- target.serviceWorkerManager = new WebInspector.ServiceWorkerManager(target);

+ if (target.hasBrowserCapability()) {

+ target.subTargetsManager = new WebInspector.SubTargetsManager(target);

+ target.serviceWorkerManager = new WebInspector.ServiceWorkerManager(target, target.subTargetsManager);

+ }

this.addTarget(target);

return target;