third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html - Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

Issue 2354973003: [DevTools] Move subtargets functionality from ServiceWorker to Target domain. (Closed)

Patch Set: review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

diff --git a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

index c121d0c2d5aee763a0c46795c5005d7be7148245..78143844d7dc7ed249f8d7c4af693af17d63ff9b 100644

--- a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

+++ b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

@@ -25,7 +25,7 @@ function test()

targets.forEach(function(target) {

var agentNames = Object.keys(target._agentsMap).filter(function(agentName) {

var agent = target._agentsMap[agentName];

- return agent["enable"] && agent["disable"] && agentName !== "ServiceWorker" && agentName !== "Security" && agentName !== "Inspector"; // async wrt others.

+ return agent["enable"] && agent["disable"] && agentName !== "ServiceWorker" && agentName !== "Security" && agentName !== "Inspector" && agentName !== "Target"; // async wrt others.

}).sort();

function disableAgent(agentName)