Handle Utf-8 BOM at beginning of an Utf-8 stream.

Handle Utf-8 BOM at beginning of an Utf-8 stream.

(This should enable to drop the BOM handling in the Blink bindings.)

R=marja@chromium.org
BUG=v8:4947
Committed: https://crrev.com/a2b8b6e7db2939255326be2cad61e0bbafb1a1b2
Cr-Commit-Position: refs/heads/master@{#39579}

[vogelheim, 2016-09-20 15:43:47]

Patchset #1 (id:1) has been deleted

[vogelheim, 2016-09-20 15:44:29]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-09-20 16:17:58]

ptal.

Blink companion cl at crrev.com/2351943003.

https://codereview.chromium.org/2354973002/diff/20001/src/parsing/scanner-cha...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2354973002/diff/20001/src/parsing/scanner-cha...
src/parsing/scanner-character-streams.cc:299: if (V8_LIKELY(t < kUtf8Bom)) {
1st + 3rd branch could be merged, but I wanted to keep the super common case
super simple. Not sure if that µ-optimization makes sense...

[commit-bot: I haz the power, 2016-09-20 16:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 16:27:03]

Dry run: This issue passed the CQ dry run.

[marja, 2016-09-20 18:52:30]

lgtm

https://codereview.chromium.org/2354973002/diff/20001/src/parsing/scanner-cha...
File src/parsing/scanner-character-streams.cc (right):

https://codereview.chromium.org/2354973002/diff/20001/src/parsing/scanner-cha...
src/parsing/scanner-character-streams.cc:299: if (V8_LIKELY(t < kUtf8Bom)) {
On 2016/09/20 16:17:58, vogelheim wrote:
> 1st + 3rd branch could be merged, but I wanted to keep the super common case
> super simple. Not sure if that µ-optimization makes sense...

I think this version is pretty readable too.

https://codereview.chromium.org/2354973002/diff/20001/test/cctest/parsing/tes...
File test/cctest/parsing/test-scanner-streams.cc (right):

https://codereview.chromium.org/2354973002/diff/20001/test/cctest/parsing/tes...
test/cctest/parsing/test-scanner-streams.cc:140: char data[1 +
arraysize(unicode_utf8)] = {"\xbf"};
... how paranoid do we want to be, should there also be a test where it's all in
one-byte chunks?

[vogelheim, 2016-09-21 07:50:54]

https://codereview.chromium.org/2354973002/diff/20001/test/cctest/parsing/tes...
File test/cctest/parsing/test-scanner-streams.cc (right):

https://codereview.chromium.org/2354973002/diff/20001/test/cctest/parsing/tes...
test/cctest/parsing/test-scanner-streams.cc:140: char data[1 +
arraysize(unicode_utf8)] = {"\xbf"};
On 2016/09/20 18:52:30, marja wrote:
> ... how paranoid do we want to be, should there also be a test where it's all
in
> one-byte chunks?

Done.

[vogelheim, 2016-09-21 07:51:03]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-09-21 07:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2354973002/#ps40001
(title: "Test w/ single-byte BOM chunks.")

[commit-bot: I haz the power, 2016-09-21 07:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 08:39:56]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-21 08:40:22]

Description was changed from

==========
Handle Utf-8 BOM at beginning of an Utf-8 stream.

(This should enable to drop the BOM handling in the Blink bindings.)

R=marja@chromium.org
BUG=v8:4947
==========

to

==========
Handle Utf-8 BOM at beginning of an Utf-8 stream.

(This should enable to drop the BOM handling in the Blink bindings.)

R=marja@chromium.org
BUG=v8:4947

Committed: https://crrev.com/a2b8b6e7db2939255326be2cad61e0bbafb1a1b2
Cr-Commit-Position: refs/heads/master@{#39579}
==========

[commit-bot: I haz the power, 2016-09-21 08:40:23]

Patchset 2 (id:??) landed as
https://crrev.com/a2b8b6e7db2939255326be2cad61e0bbafb1a1b2
Cr-Commit-Position: refs/heads/master@{#39579}