Fix a memory leak reported by clang static analyzer.

Fix a memory leak reported by clang static analyzer.

The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]: https://developer.apple.com/library/content/documentation/CoreFoundation/Conceptual/CFMemoryMgmt/Concepts/Ownership.html#//apple_ref/doc/uid/20001148-103029

BUG=648210
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354963002

Committed: https://skia.googlesource.com/skia/+/388127f1927ec6ba699a925969fd38a86cf56b3a

[sdefresne, 2016-09-20 14:55:26]

Description was changed from

==========
Fix a memory leak reported by clang static analyzer.

The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]:
https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

BUG=648210
==========

to

==========
Fix a memory leak reported by clang static analyzer.

The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]:
https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

BUG=648210
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354963002
==========

[sdefresne, 2016-09-20 14:55:29]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-09-20 15:08:15]

sdefresne@chromium.org changed reviewers:
+ bsalomon@google.com

[sdefresne, 2016-09-20 15:08:15]

Please take a look.

Note that this CL was made against a checkout of skia in a Chromium tree and may
have to be moved to a proper checkout of skia.

[bsalomon, 2016-09-20 15:12:40]

lgtm

[commit-bot: I haz the power, 2016-09-20 15:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:35:14]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-09-20 15:51:48]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-09-20 15:51:53]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-09-20 15:52:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 15:53:15]

Description was changed from

==========
Fix a memory leak reported by clang static analyzer.

The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]:
https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

BUG=648210
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354963002
==========

to

==========
Fix a memory leak reported by clang static analyzer.

The CFStringCreateWithCString method respect the "Create Rule" [1]
regarding the ownership of the returned reference. This means that
the object needs to be deallocated explicitly by calling CFRelease.

[1]:
https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

BUG=648210
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354963002

Committed:
https://skia.googlesource.com/skia/+/388127f1927ec6ba699a925969fd38a86cf56b3a
==========

[commit-bot: I haz the power, 2016-09-20 15:53:16]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/388127f1927ec6ba699a925969fd38a86cf56b3a