Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2354943002: Auto-generate much of the help text for --config to reduce maintenance (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Auto-generate much of the help text for --config to reduce maintenance The list of configs, and the details about all predefined configs are now built directly from the gPredefinedConfigs array. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354943002 Committed: https://skia.googlesource.com/skia/+/37e233495ac2cc3c8dcac5f1d4055df161556860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -112 lines) Patch
M tools/flags/SkCommonFlagsConfig.cpp View 2 chunks +75 lines, -112 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Brian Osman
4 years, 3 months ago (2016-09-20 14:21:29 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-09-20 14:23:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354943002/1
4 years, 3 months ago (2016-09-20 14:25:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 15:06:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/37e233495ac2cc3c8dcac5f1d4055df161556860

Powered by Google App Engine
This is Rietveld 408576698