arc: bluetooth: Clean up arc_bluetooth_bridge

arc: bluetooth: Clean up arc_bluetooth_bridge

- Remove BluetoothAdadpter::Observer::AdapterPoweredChanged
  as Chrome to Android BT enable/disable are implemented in
  ArcIntentHelperBridge instead.
- Mark SetRemoteDeviceProperty() as unsupported API.
- Add 120 seconds timeout to Bluetooth Device scans.
- Add missing implementation in GetAdapterProperty.

BUG=646584
TEST=Unit test and CTS passed on minnie.

Committed: https://crrev.com/d14e966090ffb39319f6baeb364426a00b5ede7b
Cr-Commit-Position: refs/heads/master@{#420460}

[puthik_chromium, 2016-09-20 20:17:26]

puthik@chromium.org changed reviewers:
+ lhchavez@chromium.org, steel@chromium.org

[puthik_chromium, 2016-09-20 20:17:26]

This is multiple small clean ups group together in 1 CL.
I will submit bigger items later in separate patches.

[Luis Héctor Chávez, 2016-09-20 20:23:11]

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:85: constexpr uint32_t
kDiscoveryTimeout = 120;
nit: base::TimeDelta::FromSeconds() is constexpr, so you can actually do:

constexpr base::TimeDelta kDiscoveryTimeout = base::TimeDelta::FromSeconds(120);

Same for all the other timeouts.

(also, the comment should read "Timeout", not "Time out").

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:888:
DCHECK(CalledOnValidThread());
nit: move to beginning of function.

[puthik_chromium, 2016-09-20 20:55:39]

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:85: constexpr uint32_t
kDiscoveryTimeout = 120;
On 2016/09/20 20:23:11, Luis Héctor Chávez wrote:
> nit: base::TimeDelta::FromSeconds() is constexpr, so you can actually do:
> 
> constexpr base::TimeDelta kDiscoveryTimeout =
base::TimeDelta::FromSeconds(120);
> 
> Same for all the other timeouts.
> 
> (also, the comment should read "Timeout", not "Time out").

Done.

https://codereview.chromium.org/2354933003/diff/20001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:888:
DCHECK(CalledOnValidThread());
On 2016/09/20 20:23:11, Luis Héctor Chávez wrote:
> nit: move to beginning of function.

Done.

[Luis Héctor Chávez, 2016-09-21 15:18:37]

lgtm

[Rahul Chaturvedi, 2016-09-21 22:40:26]

lgtm % nit

https://codereview.chromium.org/2354933003/diff/40001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2354933003/diff/40001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:85: constexpr base::TimeDelta
kDiscoveryTimeout = base::TimeDelta::FromSeconds(120);
Mention in comment why 2 minutes.

[puthik_chromium, 2016-09-22 00:26:55]

https://codereview.chromium.org/2354933003/diff/40001/components/arc/bluetoot...
File components/arc/bluetooth/arc_bluetooth_bridge.cc (right):

https://codereview.chromium.org/2354933003/diff/40001/components/arc/bluetoot...
components/arc/bluetooth/arc_bluetooth_bridge.cc:85: constexpr base::TimeDelta
kDiscoveryTimeout = base::TimeDelta::FromSeconds(120);
On 2016/09/21 22:40:26, Rahul Chaturvedi wrote:
> Mention in comment why 2 minutes.

Done.

[puthik_chromium, 2016-09-22 20:37:43]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-09-22 20:37:43]

The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org,
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2354933003/#ps60001
(title: "Add more comment")

[commit-bot: I haz the power, 2016-09-22 20:38:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:23:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 21:25:39]

Description was changed from

==========
arc: bluetooth: Clean up arc_bluetooth_bridge

- Remove BluetoothAdadpter::Observer::AdapterPoweredChanged
  as Chrome to Android BT enable/disable are implemented in
  ArcIntentHelperBridge instead.
- Mark SetRemoteDeviceProperty() as unsupported API.
- Add 120 seconds timeout to Bluetooth Device scans.
- Add missing implementation in GetAdapterProperty.

BUG=646584
TEST=Unit test and CTS passed on minnie.
==========

to

==========
arc: bluetooth: Clean up arc_bluetooth_bridge

- Remove BluetoothAdadpter::Observer::AdapterPoweredChanged
  as Chrome to Android BT enable/disable are implemented in
  ArcIntentHelperBridge instead.
- Mark SetRemoteDeviceProperty() as unsupported API.
- Add 120 seconds timeout to Bluetooth Device scans.
- Add missing implementation in GetAdapterProperty.

BUG=646584
TEST=Unit test and CTS passed on minnie.

Committed: https://crrev.com/d14e966090ffb39319f6baeb364426a00b5ede7b
Cr-Commit-Position: refs/heads/master@{#420460}
==========

[commit-bot: I haz the power, 2016-09-22 21:25:40]

Patchset 4 (id:??) landed as
https://crrev.com/d14e966090ffb39319f6baeb364426a00b5ede7b
Cr-Commit-Position: refs/heads/master@{#420460}