deleteDatabase() success should be IDBVersionChangeEvent [Blink]

deleteDatabase() success should be IDBVersionChangeEvent [Blink]

Found via the W3C web-platform-tests. Once the back-end is
sending the version to the front-end (through existing plumbing),
create and populate the correct kind of event, per the spec.

Blink side must land first, then Chromium side, then Blink tests.

BUG=362251
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171382

[jsbell, 2014-04-11 18:48:19]

cmumford@, dgrogan@ - please take a look?

Blink side will land to handle onSuccess(int) in IDBOpenDBRequest, then Chromium
side (to call onSuccess(int) instead of onSuccess()), then Blink tests.

I'll split the new layout test out of this CL before landing. It's implemented
as a W3C-style tests, since it's a simple conformance test.

[cmumford, 2014-04-11 19:36:45]

Will this compile w/o a change in Source/modules/indexeddb/IDBRequest.h?

https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
File LayoutTests/storage/indexeddb/deleteDatabase-event.html (right):

https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
LayoutTests/storage/indexeddb/deleteDatabase-event.html:40: 'and have the
newVersion property set to null.');
event.target.result === undefined is also part of the spec.

[jsbell, 2014-04-11 20:20:20]

> Will this compile w/o a change in Source/modules/indexeddb/IDBRequest.h?

Can you be more specific? It WFM...

https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
File LayoutTests/storage/indexeddb/deleteDatabase-event.html (right):

https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
LayoutTests/storage/indexeddb/deleteDatabase-event.html:40: 'and have the
newVersion property set to null.');
On 2014/04/11 19:36:45, cmumford wrote:
> event.target.result === undefined is also part of the spec.

Thanks, added an assertion.

[cmumford, 2014-04-11 20:24:51]

On 2014/04/11 20:20:20, jsbell wrote:
> > Will this compile w/o a change in Source/modules/indexeddb/IDBRequest.h?
> 
> Can you be more specific? It WFM...
> 
>
https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
> File LayoutTests/storage/indexeddb/deleteDatabase-event.html (right):
> 
>
https://codereview.chromium.org/235493003/diff/1/LayoutTests/storage/indexedd...
> LayoutTests/storage/indexeddb/deleteDatabase-event.html:40: 'and have the
> newVersion property set to null.');
> On 2014/04/11 19:36:45, cmumford wrote:
> > event.target.result === undefined is also part of the spec.
> 
> Thanks, added an assertion.

I see now, I didn't realize you used an existing function in defined in
IDBRequest.h vs. defining a new one.

Also, if you land the test in this CL will the layout tests start failing, or is
it somehow disconnected until later?

[dgrogan, 2014-04-11 20:28:37]

lgtm

https://codereview.chromium.org/235493003/diff/20001/LayoutTests/storage/inde...
File LayoutTests/storage/indexeddb/deleteDatabase-event-expected.txt (right):

https://codereview.chromium.org/235493003/diff/20001/LayoutTests/storage/inde...
LayoutTests/storage/indexeddb/deleteDatabase-event-expected.txt:3: PASS
deleteDatabase success event, non-exitent DB
typo: existent

[jsbell, 2014-04-11 21:04:52]

https://codereview.chromium.org/235493003/diff/20001/LayoutTests/storage/inde...
File LayoutTests/storage/indexeddb/deleteDatabase-event-expected.txt (right):

https://codereview.chromium.org/235493003/diff/20001/LayoutTests/storage/inde...
LayoutTests/storage/indexeddb/deleteDatabase-event-expected.txt:3: PASS
deleteDatabase success event, non-exitent DB
On 2014/04/11 20:28:37, dgrogan wrote:
> typo: existent

Done.

[jsbell, 2014-04-11 21:05:29]

On 2014/04/11 20:24:51, cmumford wrote:
> Also, if you land the test in this CL will the layout tests start failing, or
is
> it somehow disconnected until later?

The layout tests will fail - I'll split them out and land them after chromium
goes in (See comment #1)

[cmumford, 2014-04-11 21:12:23]

Then the version w/o the test lgtm.

[jsbell, 2014-04-11 23:19:06]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-04-11 23:19:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/235493003/80001

[commit-bot: I haz the power, 2014-04-12 00:23:20]

Change committed as 171382