Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2354923003: Fix leaks related to the usage of JSE runtime data (Closed)

Created:
4 years, 3 months ago by Wei Li
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix leaks related to the usage of JSE runtime data Per isolate runtime data should be deleted when the associated isolate's destructed. Also, the internal of per isolate runtime data is obscure to the JS engine. So XFA or this class itself has to be in charge of the memory management. Use smart pointer for it so that the resource could be released properly. BUG=pdfium:242 Committed: https://pdfium.googlesource.com/pdfium/+/54be7be992f1cde40b9d5c0e55a119c6cc4e4e02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M fxjs/cfxjse_runtimedata.h View 2 chunks +3 lines, -1 line 0 comments Download
M fxjs/cfxjse_runtimedata.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M fxjs/fxjs_v8.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M fxjs/include/fxjs_v8.h View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Wei Li
pls review, thanks
4 years, 3 months ago (2016-09-21 17:16:12 UTC) #7
dsinclair
lgtm
4 years, 3 months ago (2016-09-21 17:19:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354923003/1
4 years, 3 months ago (2016-09-21 17:19:35 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:19:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/54be7be992f1cde40b9d5c0e55a119c6cc4e...

Powered by Google App Engine
This is Rietveld 408576698