chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 23549039: Preparing to support fragment resolution against non-hierarchical schemes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 23549039: Preparing to support fragment resolution against non-hierarchical schemes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index d0f23482891b179d8b8324de4170ba74cb5798f8..3379d8b2841543c9cc828288207ed4411c59c542 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1342,7 +1342,7 @@ bool TabsUpdateFunction::UpdateURL(const std::string &url_string,

script_executor()->ExecuteScript(

extension_id(),

ScriptExecutor::JAVASCRIPT,

- url.path(),

+ url.GetContent(),

ScriptExecutor::TOP_FRAME,

UserScript::DOCUMENT_IDLE,

ScriptExecutor::MAIN_WORLD,

« no previous file with comments | « chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc ('k') | chrome_frame/navigation_constraints.cc » ('j') | url/gurl.cc » ('J')