Preparing to support fragment resolution against non-hierarchical schemes

url/gurl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef URL_GURL_H_
 #define URL_GURL_H_
 
 #include <iosfwd>
 #include <string>
 
@@ skipping 205 matching lines @@
   bool SchemeIsFileSystem() const {
     return SchemeIs("filesystem");
   }
 
   // If the scheme indicates a secure connection
   bool SchemeIsSecure() const {
     return SchemeIs("https") || SchemeIs("wss") ||
         (SchemeIsFileSystem() && inner_url() && inner_url()->SchemeIsSecure());
   }
 
+  // The "content" or the URL is everything after the scheme (skipping the
+  // scheme delimiting colon), or the entire URL if it has no scheme.

[joth, 2013/09/19 22:50:02]

Probably safer as:

// The "content" or the URL is everything after the scheme (skipping the scheme
delimiting colon). It is an error to get the origin of an invalid URL. The
result will be an empty string.

...
return is_valid_ ? ComponentString(parsed_.GetContent()) : "";

we should probably move the function body to the .cc too

[Kristian Monsen, 2013/09/20 05:57:31]

Done.

+  std::string GetContent() const {
+    return ComponentString(parsed_.GetContent());
+  }
+
   // Returns true if the hostname is an IP address. Note: this function isn't
   // as cheap as a simple getter because it re-parses the hostname to verify.
   // This currently identifies only IPv4 addresses (bug 822685).
   bool HostIsIPAddress() const;
 
   // Getters for various components of the URL. The returned string will be
   // empty if the component is empty or is not present.
   std::string scheme() const {  // Not including the colon. See also SchemeIs.
     return ComponentString(parsed_.scheme);
   }
@@ skipping 133 matching lines @@
   // Used for nested schemes [currently only filesystem:].
   GURL* inner_url_;
 
   // TODO bug 684583: Add encoding for query params.
 };
 
 // Stream operator so GURL can be used in assertion statements.
 URL_EXPORT std::ostream& operator<<(std::ostream& out, const GURL& url);
 
 #endif  // URL_GURL_H_