Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606
Committed: https://crrev.com/d49b99a5517d33b68ba4d0d8f281a1fe95738c27
Cr-Commit-Position: refs/heads/master@{#420009}

[keishi, 2016-09-21 05:00:42]

Description was changed from

==========
Use CrossThreadPersistent for file system api

BUG=591606
==========

to

==========
Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606
==========

[keishi, 2016-09-21 05:00:42]

keishi@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[keishi, 2016-09-21 05:01:01]

PTAL. Split from https://codereview.chromium.org/2335063003/

[haraken, 2016-09-21 07:09:55]

LGTM

[keishi, 2016-09-21 07:21:02]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2016-09-21 07:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-09-21 08:07:22]

Just curious: How did you find this issue? After enabling the per-thread heap on
DedicatedWorker, does the compiler or something detect this? I'm wondering
whether other APIs that can be called from DedicatedWorker (e.g., IndexedDB)
need the same fix.

[commit-bot: I haz the power, 2016-09-21 09:04:22]

Description was changed from

==========
Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606
==========

to

==========
Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606
==========

[commit-bot: I haz the power, 2016-09-21 09:04:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 09:06:32]

Description was changed from

==========
Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606
==========

to

==========
Use CrossThreadPersistent for LocalFileSystem

Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker.

Required to enable per thread heap on DedicatedWorker.

BUG=591606

Committed: https://crrev.com/d49b99a5517d33b68ba4d0d8f281a1fe95738c27
Cr-Commit-Position: refs/heads/master@{#420009}
==========

[commit-bot: I haz the power, 2016-09-21 09:06:33]

Patchset 1 (id:??) landed as
https://crrev.com/d49b99a5517d33b68ba4d0d8f281a1fe95738c27
Cr-Commit-Position: refs/heads/master@{#420009}

[keishi, 2016-09-21 09:13:26]

On 2016/09/21 08:07:22, nhiroki wrote:
> Just curious: How did you find this issue? After enabling the per-thread heap
on
> DedicatedWorker, does the compiler or something detect this? I'm wondering
> whether other APIs that can be called from DedicatedWorker (e.g., IndexedDB)
> need the same fix.

For debug builds, when assigning a pointer to a Member, we check if the object's
owner ThreadHeap matches the Member's ThreadHeap.
I found this by running layout tests.