Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2354903004: Use CrossThreadPersistent for LocalFileSystem (Closed)

Created:
4 years, 3 months ago by keishi
Modified:
4 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use CrossThreadPersistent for LocalFileSystem Use CrossThreadPersistent for LocalFileSystem in case its used from a Worker. Required to enable per thread heap on DedicatedWorker. BUG=591606 Committed: https://crrev.com/d49b99a5517d33b68ba4d0d8f281a1fe95738c27 Cr-Commit-Position: refs/heads/master@{#420009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
keishi
PTAL. Split from https://codereview.chromium.org/2335063003/
4 years, 3 months ago (2016-09-21 05:01:01 UTC) #3
haraken
LGTM
4 years, 3 months ago (2016-09-21 07:09:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354903004/1
4 years, 3 months ago (2016-09-21 07:21:24 UTC) #6
nhiroki
Just curious: How did you find this issue? After enabling the per-thread heap on DedicatedWorker, ...
4 years, 3 months ago (2016-09-21 08:07:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 09:04:23 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d49b99a5517d33b68ba4d0d8f281a1fe95738c27 Cr-Commit-Position: refs/heads/master@{#420009}
4 years, 3 months ago (2016-09-21 09:06:33 UTC) #11
keishi
4 years, 3 months ago (2016-09-21 09:13:26 UTC) #12
Message was sent while issue was closed.
On 2016/09/21 08:07:22, nhiroki wrote:
> Just curious: How did you find this issue? After enabling the per-thread heap
on
> DedicatedWorker, does the compiler or something detect this? I'm wondering
> whether other APIs that can be called from DedicatedWorker (e.g., IndexedDB)
> need the same fix.

For debug builds, when assigning a pointer to a Member, we check if the object's
owner ThreadHeap matches the Member's ThreadHeap.
I found this by running layout tests.

Powered by Google App Engine
This is Rietveld 408576698