Don't include the tracing in gpu_memory_buffer.h

Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525
Cr-Commit-Position: refs/heads/master@{#420232}

[ccameron, 2016-09-20 19:17:58]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

BUG=648707
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-09-20 19:17:59]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-20 19:18:04]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 19:24:22]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:25:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 19:28:55]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-20 19:28:55]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:38:11]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-20 20:02:54]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 20:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:18:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ccameron, 2016-09-20 20:20:24]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:20:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 20:21:23]

So, that ended up being a really long thread to pull ...

This takes the tracing include out of gpu_memory_buffer.h, and then fixes a
bazillion files that were relying on that (usually for trace_event, bind, or
single_thread_runner)

[erikchen, 2016-09-20 20:33:27]

yay for IWYU. minor nit, lgtm.

https://codereview.chromium.org/2354903003/diff/60001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2354903003/diff/60001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:18: buffer_id);
Why is the implementation here instead of gmb_tracing.cc?

[commit-bot: I haz the power, 2016-09-20 20:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:37:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ccameron, 2016-09-20 22:36:32]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 22:38:07]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:38:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 23:08:10]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 23:22:06]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:22:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-20 23:41:14]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:42:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:34:44]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ccameron, 2016-09-21 23:01:36]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:38:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ccameron, 2016-09-21 23:47:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-21 23:47:50]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-22 00:07:21]

Thanks! Trying to ram this through now (terribly moving target ... Linux builds
got 2 more breaks in 1 day).

https://codereview.chromium.org/2354903003/diff/60001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2354903003/diff/60001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:18: buffer_id);
On 2016/09/20 20:33:26, erikchen wrote:
> Why is the implementation here instead of gmb_tracing.cc?

Mmh, might as well be in a _tracing.cc. Moved.

[ccameron, 2016-09-22 00:07:30]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2016-09-22 00:07:37]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-09-22 00:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2354903003/#ps200001
(title: "Fix linux build again")

[commit-bot: I haz the power, 2016-09-22 00:08:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 01:46:41]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-22 01:46:43]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-09-22 01:48:13]

Description was changed from

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't include the tracing in gpu_memory_buffer.h

This will be included in blink, and we should avoid taking up these
dependencies.

It turns out that this file was pulling in many required headers in many
files. Do these includes directly.

TBR=hubbe,torne,piman
BUG=648707
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525
Cr-Commit-Position: refs/heads/master@{#420232}
==========

[commit-bot: I haz the power, 2016-09-22 01:48:14]

Patchset 11 (id:??) landed as
https://crrev.com/9c48d1d4786798ab90251e4131a2e808faffe525
Cr-Commit-Position: refs/heads/master@{#420232}