Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 23549019: store ics for js api accessors (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : no snprintf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -110 lines) Patch
M src/arm/stub-cache-arm.cc View 1 3 chunks +49 lines, -13 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 3 chunks +53 lines, -17 lines 0 comments Download
M src/ic.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/stub-cache.h View 2 chunks +11 lines, -0 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 3 chunks +53 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 1 chunk +82 lines, -62 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcarney
ptal
7 years, 3 months ago (2013-09-05 13:17:33 UTC) #1
Michael Starzinger
LGTM. Can we haz test coverage? https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (left): https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359 src/ia32/stub-cache-ia32.cc:1359: ASSERT(call_optimization.is_simple_api_call()); nit: Can ...
7 years, 3 months ago (2013-09-05 16:24:49 UTC) #2
dcarney
yep, will add tests https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (left): https://codereview.chromium.org/23549019/diff/1/src/ia32/stub-cache-ia32.cc#oldcode1359 src/ia32/stub-cache-ia32.cc:1359: ASSERT(call_optimization.is_simple_api_call()); On 2013/09/05 16:24:49, Michael ...
7 years, 3 months ago (2013-09-05 19:25:46 UTC) #3
dcarney
7 years, 3 months ago (2013-09-06 11:32:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698