Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 23549013: Preserves callee-saved FPU registers on ARM (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/assembler_arm.cc ('K') | « runtime/vm/stack_frame_arm.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
===================================================================
--- runtime/vm/stub_code_arm.cc (revision 27062)
+++ runtime/vm/stub_code_arm.cc (working copy)
@@ -782,10 +782,15 @@
__ EnterStubFrame();
// Save new context and C++ ABI callee-saved registers.
- const intptr_t kNewContextOffset =
+ const intptr_t kNewContextOffsetFromFp =
-(1 + kAbiPreservedCpuRegCount) * kWordSize;
__ PushList((1 << R3) | kAbiPreservedCpuRegs);
+ const DRegister firstd = EvenDRegisterOf(kAbiFirstPreservedFpuReg);
+ ASSERT(2 * kAbiPreservedFpuRegCount < 16);
+ // Save FPU registers. 2 D registers per Q register.
+ __ vstmd(DB_W, SP, firstd, 2 * kAbiPreservedFpuRegCount);
+
// The new Context structure contains a pointer to the current Isolate
// structure. Cache the Context pointer in the CTX register so that it is
// available in generated code and calls to Isolate::Current() need not be
@@ -813,13 +818,10 @@
// The constants kSavedContextSlotFromEntryFp and
// kExitLinkSlotFromEntryFp must be kept in sync with the code below.
- ASSERT(kExitLinkSlotFromEntryFp == -9);
- ASSERT(kSavedContextSlotFromEntryFp == -10);
+ ASSERT(kExitLinkSlotFromEntryFp == -25);
+ ASSERT(kSavedContextSlotFromEntryFp == -26);
__ PushList((1 << R4) | (1 << R5));
- // The stack pointer is restored after the call to this location.
- const intptr_t kSavedContextSlotFromEntryFp = -10 * kWordSize;
-
// Load arguments descriptor array into R4, which is passed to Dart code.
__ ldr(R4, Address(R1, VMHandles::kOffsetOfRawPtrInHandle));
@@ -850,11 +852,11 @@
__ blx(R0); // R4 is the arguments descriptor array.
// Read the saved new Context pointer.
- __ ldr(CTX, Address(FP, kNewContextOffset));
+ __ ldr(CTX, Address(FP, kNewContextOffsetFromFp));
__ ldr(CTX, Address(CTX, VMHandles::kOffsetOfRawPtrInHandle));
// Get rid of arguments pushed on the stack.
- __ AddImmediate(SP, FP, kSavedContextSlotFromEntryFp);
+ __ AddImmediate(SP, FP, kSavedContextSlotFromEntryFp * kWordSize);
// Load Isolate pointer from Context structure into CTX. Drop Context.
__ ldr(CTX, FieldAddress(CTX, Context::isolate_offset()));
@@ -868,6 +870,9 @@
__ StoreToOffset(kWord, R5, CTX, Isolate::top_exit_frame_info_offset());
// Restore C++ ABI callee-saved registers.
+ // Restore FPU registers. 2 D registers per Q register.
+ __ vldmd(IA_W, SP, firstd, 2 * kAbiPreservedFpuRegCount);
+ // Restore CPU registers.
__ PopList((1 << R3) | kAbiPreservedCpuRegs); // Ignore restored R3.
// Restore the frame pointer and return.
« runtime/vm/assembler_arm.cc ('K') | « runtime/vm/stack_frame_arm.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698