Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 23549011: remove Isolate::Current from most files starting with 's' through 'v' (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove Isolate::Current from most files starting with 's' through 'v' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16507

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -136 lines) Patch
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mksnapshot.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/serialize.h View 8 chunks +14 lines, -11 lines 1 comment Download
M src/serialize.cc View 12 chunks +21 lines, -23 lines 0 comments Download
M src/snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot-common.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/spaces.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spaces.cc View 7 chunks +8 lines, -12 lines 0 comments Download
M src/string-stream.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/string-stream.cc View 5 chunks +15 lines, -16 lines 0 comments Download
M src/transitions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/transitions.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/v8threads.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8threads.cc View 3 chunks +5 lines, -6 lines 1 comment Download
M test/cctest/test-accessors.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 13 chunks +26 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-03 11:02:35 UTC) #1
Sven Panne
LGTM with a nit https://codereview.chromium.org/23549011/diff/1/src/serialize.h File src/serialize.h (right): https://codereview.chromium.org/23549011/diff/1/src/serialize.h#newcode477 src/serialize.h:477: Isolate* isolate() { return isolate_; ...
7 years, 3 months ago (2013-09-03 11:38:55 UTC) #2
dcarney
7 years, 3 months ago (2013-09-03 11:54:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698