Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 23549010: Move global V8::IsDead() into the Isolate. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Move global V8::IsDead() into the Isolate. R=yangguo@chromium.org BUG=v8:2744 Committed: http://code.google.com/p/v8/source/detail?r=16496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M src/api.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M src/isolate.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/v8.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/v8.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-02 18:53:06 UTC) #1
Yang
On 2013/09/02 18:53:06, Michael Starzinger wrote: lgtm.
7 years, 3 months ago (2013-09-03 08:35:35 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-09-03 09:36:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698