Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: LayoutTests/fast/js/select-options-remove-expected.txt

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/js/select-options-remove-expected.txt
diff --git a/LayoutTests/fast/js/select-options-remove-expected.txt b/LayoutTests/fast/js/select-options-remove-expected.txt
index 4c1abef6de9bb6d7f9404d86bd603be949b1d81c..b9ddd2aa31daac166a9c16eb45464e1c3cb2faa6 100644
--- a/LayoutTests/fast/js/select-options-remove-expected.txt
+++ b/LayoutTests/fast/js/select-options-remove-expected.txt
@@ -54,7 +54,7 @@ PASS select1.options.length is 0
PASS select1.selectedIndex is -1
1.11 Remove too many args from empty Options
-PASS select1.options.remove(0, 'foo') is undefined
+PASS select1.options.remove(0, 'foo') threw exception TypeError: Type error.
PASS select1.options.length is 0
PASS select1.selectedIndex is -1
@@ -78,6 +78,11 @@ PASS select1.options.remove(1) is undefined
PASS select1.options.length is 0
PASS select1.selectedIndex is -1
+1.16 Detach select element
+PASS select1.parentNode is not null
+PASS select1.remove() is undefined
+PASS select1.parentNode is null
+
2.1 Remove (object) from non-empty Options
PASS select2.options.remove(value) is undefined
PASS select2.options.length is 15
@@ -145,36 +150,41 @@ PASS select2.selectedIndex is 3
PASS select2.options[0].value is 'L'
2.12 Remove too many args from non-empty Options
-PASS select2.options.remove(0, 'foo') is undefined
-PASS select2.options.length is 4
-PASS select2.selectedIndex is 2
-PASS select2.options[0].value is 'M'
+PASS select2.options.remove(0, 'foo') threw exception TypeError: Type error.
+PASS select2.options.length is 5
+PASS select2.selectedIndex is 3
+PASS select2.options[0].value is 'L'
2.13 Remove invalid index -2 from non-empty Options
PASS select2.options.remove(-2) is undefined
-PASS select2.options.length is 4
-PASS select2.selectedIndex is 2
-PASS select2.options[2].value is 'O'
+PASS select2.options.length is 5
+PASS select2.selectedIndex is 3
+PASS select2.options[2].value is 'N'
2.14 Remove invalid index -1 from non-empty Options
PASS select2.options.remove(-1) is undefined
-PASS select2.options.length is 4
-PASS select2.selectedIndex is 2
-PASS select2.options[3].value is 'P'
+PASS select2.options.length is 5
+PASS select2.selectedIndex is 3
+PASS select2.options[3].value is 'O'
2.15 Remove index 0 from non-empty Options
PASS select2.options.remove(0) is undefined
-PASS select2.options.length is 3
-PASS select2.selectedIndex is 1
-PASS select2.options[0].value is 'N'
+PASS select2.options.length is 4
+PASS select2.selectedIndex is 2
+PASS select2.options[0].value is 'M'
2.16 Remove index 1 from non-empty Options
PASS select2.options.remove(1) is undefined
-PASS select2.options.length is 2
-PASS select2.selectedIndex is 0
-PASS select2.options[1].value is 'P'
+PASS select2.options.length is 3
+PASS select2.selectedIndex is 1
+PASS select2.options[1].value is 'O'
+
+2.17 Detach select element
+PASS select2.parentNode is not null
+PASS select2.remove() is undefined
+PASS select2.parentNode is null
PASS successfullyParsed is true
TEST COMPLETE
-
+

Powered by Google App Engine
This is Rietveld 408576698