Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Side by Side Diff: Source/core/html/HTMLSelectElement.h

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 virtual void reset() OVERRIDE; 54 virtual void reset() OVERRIDE;
55 55
56 unsigned length() const; 56 unsigned length() const;
57 57
58 int size() const { return m_size; } 58 int size() const { return m_size; }
59 bool multiple() const { return m_multiple; } 59 bool multiple() const { return m_multiple; }
60 60
61 bool usesMenuList() const; 61 bool usesMenuList() const;
62 62
63 void add(HTMLElement*, HTMLElement* beforeElement, ExceptionState&); 63 void add(HTMLElement*, HTMLElement* beforeElement, ExceptionState&);
64
65 using Node::remove;
64 void remove(int index); 66 void remove(int index);
65 void remove(HTMLOptionElement*); 67 void remove(HTMLOptionElement*);
66 68
67 String value() const; 69 String value() const;
68 void setValue(const String&); 70 void setValue(const String&);
69 71
70 PassRefPtr<HTMLOptionsCollection> options(); 72 PassRefPtr<HTMLOptionsCollection> options();
71 PassRefPtr<HTMLCollection> selectedOptions(); 73 PassRefPtr<HTMLCollection> selectedOptions();
72 74
73 void optionElementChildrenChanged(); 75 void optionElementChildrenChanged();
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 { 214 {
213 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::select Tag)); 215 ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::select Tag));
214 return static_cast<HTMLSelectElement*>(node); 216 return static_cast<HTMLSelectElement*>(node);
215 } 217 }
216 218
217 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast. 219 void toHTMLSelectElement(const HTMLSelectElement*); // This overload will catch anyone doing an unnecessary cast.
218 220
219 } // namespace 221 } // namespace
220 222
221 #endif 223 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698