Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: Source/core/html/HTMLOptionsCollection.idl

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * Copyright (C) 2013 Samsung Electronics. All rights reserved.
4 * 5 *
5 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
9 * 10 *
10 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 14 * Library General Public License for more details.
(...skipping 11 matching lines...) Expand all
25 attribute long selectedIndex; 26 attribute long selectedIndex;
26 [CustomSetter, SetterRaisesException] attribute unsigned long length; 27 [CustomSetter, SetterRaisesException] attribute unsigned long length;
27 [ImplementedAs=item] getter Node(unsigned long index); 28 [ImplementedAs=item] getter Node(unsigned long index);
28 [ImplementedAs=anonymousIndexedSetter, RaisesException] setter HTMLOptionEle ment (unsigned long index, [TreatNullAs=anonymousIndexedSetterRemove, TreatUndef inedAs=anonymousIndexedSetterRemove] HTMLOptionElement value); 29 [ImplementedAs=anonymousIndexedSetter, RaisesException] setter HTMLOptionEle ment (unsigned long index, [TreatNullAs=anonymousIndexedSetterRemove, TreatUndef inedAs=anonymousIndexedSetterRemove] HTMLOptionElement value);
29 [ImplementedAs=anonymousNamedGetter, NotEnumerable] getter (NodeList or Node )(DOMString name); 30 [ImplementedAs=anonymousNamedGetter, NotEnumerable] getter (NodeList or Node )(DOMString name);
30 31
31 [Custom] Node namedItem([Default=Undefined] optional DOMString name); 32 [Custom] Node namedItem([Default=Undefined] optional DOMString name);
32 33
33 [Custom, RaisesException] void add([Default=Undefined] optional HTMLOptionEl ement option, 34 [Custom, RaisesException] void add([Default=Undefined] optional HTMLOptionEl ement option,
34 optional unsigned long index); 35 optional unsigned long index);
35 [Custom] void remove([Default=Undefined] optional unsigned long index); 36 void remove([Default=Undefined] optional unsigned long index);
arv (Not doing code reviews) 2013/08/29 13:33:23 We should make this non optional as required by th
do-not-use 2013/08/29 14:27:23 HTMLOptionsCollection is not an Element, therefore
37 void remove(HTMLOptionElement option); // Non standard.
36 }; 38 };
37 39
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698