Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

Issue 23549004: Fix the HTMLSelectElement.prototype.remove() method (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are
6 * met:
7 *
8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above
11 * copyright notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the
13 * distribution.
14 * * Neither the name of Google Inc. nor the names of its
15 * contributors may be used to endorse or promote products derived from
16 * this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */
30
31 #include "config.h"
32 #include "bindings/v8/custom/V8HTMLSelectElementCustom.h"
33
34 #include "core/html/HTMLOptionElement.h"
35 #include "core/html/HTMLOptionsCollection.h"
36 #include "core/html/HTMLSelectElement.h"
37
38 #include "V8HTMLOptionElement.h"
39 #include "V8HTMLSelectElement.h"
40 #include "V8Node.h"
41 #include "V8NodeList.h"
42 #include "bindings/v8/V8Binding.h"
43
44 namespace WebCore {
45
46 void V8HTMLSelectElement::removeMethodCustom(const v8::FunctionCallbackInfo<v8:: Value>& args)
47 {
48 HTMLSelectElement* imp = V8HTMLSelectElement::toNative(args.Holder());
49 removeElement(imp, args);
50 }
51
52 void removeElement(HTMLSelectElement* imp, const v8::FunctionCallbackInfo<v8::Va lue>& args)
53 {
54 if (V8HTMLOptionElement::HasInstance(args[0], args.GetIsolate(), worldType(a rgs.GetIsolate()))) {
55 HTMLOptionElement* element = V8HTMLOptionElement::toNative(v8::Handle<v8 ::Object>::Cast(args[0]));
56 imp->remove(element->index());
57 return;
58 }
59
60 imp->remove(toInt32(args[0]));
61 }
62
63 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698