Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2354893002: Introduce VisiblePosition::isValid (Closed)
Patch Set: 201609211817 Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 8389684c3bb0a35ded794d25debfa5fae2dbaedd..09d07a49bf76a65a8a52f2de2be4c5b7afea0d12 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -1337,14 +1337,14 @@ static inline LayoutPoint absoluteLineDirectionPointToLocalPointInBlock(RootInli
VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, LayoutUnit lineDirectionPoint, EditableType editableType)
{
+ DCHECK(visiblePosition.isValid());
+
Position p = visiblePosition.deepEquivalent();
Node* node = p.anchorNode();
if (!node)
return VisiblePosition();
- DCHECK(!node->document().needsLayoutTreeUpdate());
-
LayoutObject* layoutObject = node->layoutObject();
if (!layoutObject)
return VisiblePosition();
@@ -1390,14 +1390,14 @@ VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, Lay
VisiblePosition nextLinePosition(const VisiblePosition& visiblePosition, LayoutUnit lineDirectionPoint, EditableType editableType)
{
+ DCHECK(visiblePosition.isValid());
+
Position p = visiblePosition.deepEquivalent();
Node* node = p.anchorNode();
if (!node)
return VisiblePosition();
- DCHECK(!node->document().needsLayoutTreeUpdate());
-
LayoutObject* layoutObject = node->layoutObject();
if (!layoutObject)
return VisiblePosition();
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698