DevTools security panel: prompt user to reload for mixed requests

third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.PanelWithSidebar}
  * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.SecurityPanel = function()
@@ skipping 751 matching lines @@
      * @param {!Function} networkFilterFn
      */
     _addMixedContentExplanation: function(parent, securityState, summary, description, filterKey, networkFilterFn)
     {
         var mixedContentExplanation = /** @type {!SecurityAgent.SecurityStateExplanation} */ ({
             "securityState": securityState,
             "summary": summary,
             "description": description
         });
 
+        var explanation = this._addExplanation(parent, mixedContentExplanation);
+
         var filterRequestCount = this._panel.filterRequestCount(filterKey);
-        var requestsAnchor = this._addExplanation(parent, mixedContentExplanation).createChild("div", "security-mixed-content link");
-        if (filterRequestCount > 0) {
-            requestsAnchor.textContent = WebInspector.UIString("View %d request%s in Network Panel", filterRequestCount, (filterRequestCount > 1 ? "s" : ""));
-        } else {
-            // Network instrumentation might not have been enabled for the page load, so the security panel does not necessarily know a count of individual mixed requests at this point. Point the user at the Network Panel which prompts them to refresh.
-            requestsAnchor.textContent = WebInspector.UIString("View requests in Network Panel");
+        if (filterRequestCount == 0) {

[pfeldman, 2016/09/20 18:14:47]

style: !filterRequestCount (Blink preferred) or
filterRequestCount === 0

[caseq, 2016/09/20 18:16:40]

"if (!filterRequestCount)" (we usually don't compare to 0, and generally use ===
instead of ==)

[estark, 2016/09/20 18:50:05]

Done.

[estark, 2016/09/20 18:50:05]

Done.

+            // Network instrumentation might not have been enabled for the page load, so the security panel does not necessarily know a count of individual mixed requests at this point. Prompt them to refresh instead of pointing them to the Network panel to get prompted to refresh.

[caseq, 2016/09/20 18:16:40]

please split into multiple lines.

[estark, 2016/09/20 18:50:05]

Done.

+            var refreshPrompt = explanation.createChild("div", "security-mixed-content");
+            refreshPrompt.textContent = WebInspector.UIString("Reload the page to record requests for HTTP resources.");
+            return;
         }
+
+        var requestsAnchor = explanation.createChild("div", "security-mixed-content link");
+        requestsAnchor.textContent = WebInspector.UIString("View %d request%s in Network Panel", filterRequestCount, (filterRequestCount > 1 ? "s" : ""));

[caseq, 2016/09/20 18:16:40]

JFYI since you were just moving this around -- this is a localization land mine,
should either be two different messages for singular/plural, or just something
like "View %d request(s)".

[estark, 2016/09/20 18:50:05]

Done.

         requestsAnchor.href = "";
         requestsAnchor.addEventListener("click", networkFilterFn);
     },
 
     _addContentWithCertErrorsExplanations: function()
     {
         if (!this._schemeIsCryptographic)
             return;
 
         if (!this._insecureContentStatus)
@@ skipping 245 matching lines @@
         row.createChild("div").textContent = key;
 
         var valueDiv = row.createChild("div");
         if (typeof value === "string") {
             valueDiv.textContent = value;
         } else {
             valueDiv.appendChild(value);
         }
     }
 }