Issue 23548039: Fix handling of Integer32 in HLoadNamedField and HStoreNamedField on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23548039: Fix handling of Integer32 in HLoadNamedField and HStoreNamedField on x64. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix handling of Integer32 in HLoadNamedField and HStoreNamedField on x64. The current implementation of Integer32 named loads and stores is broken on x64. R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16750

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -5 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View		4 chunks	+24 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Hey danno, We need a working Integer32 named field load for the NumberToStringStub hydrogen version ...

7 years, 3 months ago (2013-09-17 08:01:01 UTC) #1

danno

I think this functionality makes sense to wrap into the macro assembler?

7 years, 3 months ago (2013-09-17 08:25:55 UTC) #2

Benedikt Meurer

7 years, 3 months ago (2013-09-17 08:55:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r16750 (presubmit successful).