Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: include/core/SkFlattenableBuffers.h

Issue 23548034: Follow up to serialization validation code (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkFlattenableSerialization.cpp » ('j') | src/core/SkFlattenableSerialization.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkFlattenableBuffers.h
diff --git a/include/core/SkFlattenableBuffers.h b/include/core/SkFlattenableBuffers.h
index b3f3684daaed8c96bf82e26ee0dd63743545ad72..f2bcf2cb6b9bd0f90904299d4e495fda8a27aff4 100644
--- a/include/core/SkFlattenableBuffers.h
+++ b/include/core/SkFlattenableBuffers.h
@@ -70,7 +70,6 @@ public:
virtual void* readEncodedString(size_t* length, SkPaint::TextEncoding encoding) = 0;
// common data structures
- virtual SkFlattenable* readFlattenable() = 0;
virtual void readPoint(SkPoint* point) = 0;
virtual void readMatrix(SkMatrix* matrix) = 0;
virtual void readIRect(SkIRect* rect) = 0;
@@ -113,6 +112,9 @@ public:
}
protected:
+ // Use readFlattenableT to enforce a type check on the flattenable read
reed1 2013/09/13 15:18:41 How does this enforce a type-check?
+ virtual SkFlattenable* readFlattenable() = 0;
+
bool fError;
private:
« no previous file with comments | « no previous file | src/core/SkFlattenableSerialization.cpp » ('j') | src/core/SkFlattenableSerialization.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698