Added logging to local discovery code

Added logging to local discovery code

Added VLOG(1) statement to local discovery code that should help track down any
bugs reproed.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222517

[Vitaly Buka (NO REVIEWS), 2013-09-10 04:47:35]

On 2013/09/10 00:13:21, Noam Samuel wrote:

Let's decide which one is primary and keep it as VLOG.
The rest we could make DVLOG

[Vitaly Buka (NO REVIEWS), 2013-09-10 04:47:40]

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_device_lister_impl.cc (right):

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:60: VLOG(1) <<
"Service added or updated in privet layer: " << service_name;
Log will have file name and line
so no need "privet layer" part

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:79: VLOG(1) <<
"Service removed in privet layer: " << service_name;
same

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:101: << " in privet
layer";
same

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/service_discovery_host_client.cc (right):

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:130:
address_family_));
All messages above have no value. It's just dumping RPC calls

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:392: << " and
watcher update " << WatcherUpdateToString(update);
For consistenly I'd move this logging from here to unitily process

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:403: VLOG(1) <<
"RunResolverCallback on browser process with id " << id
"on browser process" part is not needed

https://codereview.chromium.org/23548028/diff/1/chrome/utility/local_discover...
File chrome/utility/local_discovery/service_discovery_message_handler.cc
(right):

https://codereview.chromium.org/23548028/diff/1/chrome/utility/local_discover...
chrome/utility/local_discovery/service_discovery_message_handler.cc:317: VLOG(1)
<< "DestroyResolver on utility process with id " << id;
no need utility "process part"

[Noam Samuel, 2013-09-10 23:01:52]

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/service_discovery_host_client.cc (right):

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:130:
address_family_));
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> All messages above have no value. It's just dumping RPC calls

If we can catch an RPC that is sent but not received, we can pinpoint a process
crash/deadlock.

[Noam Samuel, 2013-09-10 23:23:34]

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_device_lister_impl.cc (right):

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:60: VLOG(1) <<
"Service added or updated in privet layer: " << service_name;
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> Log will have file name and line
> so no need "privet layer" part

Done.

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:79: VLOG(1) <<
"Service removed in privet layer: " << service_name;
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> same

Done.

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_device_lister_impl.cc:101: << " in privet
layer";
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> same

Done.

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/service_discovery_host_client.cc (right):

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:392: << " and
watcher update " << WatcherUpdateToString(update);
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> For consistenly I'd move this logging from here to unitily process

Done.

https://codereview.chromium.org/23548028/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/service_discovery_host_client.cc:403: VLOG(1) <<
"RunResolverCallback on browser process with id " << id
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> "on browser process" part is not needed

Done.

https://codereview.chromium.org/23548028/diff/1/chrome/utility/local_discover...
File chrome/utility/local_discovery/service_discovery_message_handler.cc
(right):

https://codereview.chromium.org/23548028/diff/1/chrome/utility/local_discover...
chrome/utility/local_discovery/service_discovery_message_handler.cc:317: VLOG(1)
<< "DestroyResolver on utility process with id " << id;
On 2013/09/10 04:47:41, Vitaly Buka wrote:
> no need utility "process part"

Done.

[Vitaly Buka (NO REVIEWS), 2013-09-10 23:34:16]

lgtm

[commit-bot: I haz the power, 2013-09-10 23:54:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23548028/22001

[commit-bot: I haz the power, 2013-09-11 12:41:52]

Change committed as 222517