Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 23548025: Introduce State to DriveIntegrationService. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Introduce State to DriveIntegrationService. This is small refactoring of DriveIntegrationService by introducing State. This is preparation of mount/enabled state migration of DriveIntegrationSerivice. By the migration, DriveIntegrationService can be obtained even before initialization. This CL supports the change. Also, by this CL, FileSystem can be deleted even before Initialize() is called. BUG=284972 TEST=Ran unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M chrome/browser/chromeos/drive/drive_integration_service.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 8 chunks +23 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-09 18:13:19 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-10 00:39:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23548025/1
7 years, 3 months ago (2013-09-10 00:41:39 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:15:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23548025/1
7 years, 3 months ago (2013-09-10 01:18:20 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:28:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23548025/1
7 years, 3 months ago (2013-09-10 01:51:55 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:02:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23548025/1
7 years, 3 months ago (2013-09-10 03:27:28 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 03:36:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23548025/1
7 years, 3 months ago (2013-09-10 05:54:17 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167242
7 years, 3 months ago (2013-09-10 08:02:12 UTC) #12
hidehiko
7 years, 3 months ago (2013-09-10 09:04:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 manually as r222231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698