src/objects.cc - Issue 23548024: Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 23548024: Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: REBASE Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 507fbfc1142ccf057a70995c112c143232a1a402..647687158f105e8054226bd4c8816dab931cd147 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4719,7 +4719,7 @@ Smi* JSReceiver::GenerateIdentityHash() {

do {

// Generate a random 32-bit hash value but limit range to fit

// within a smi.

- hash_value = V8::RandomPrivate(isolate) & Smi::kMaxValue;

+ hash_value = isolate->random_number_generator()->NextInt() & Smi::kMaxValue;

attempts++;

} while (hash_value == 0 && attempts < 30);

hash_value = hash_value != 0 ? hash_value : 1; // never return 0

« no previous file with comments | « src/isolate-inl.h ('k') | src/platform.h » ('j') | no next file with comments »