Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context.

src/platform/time.h

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 204 matching lines @@
   // For timing sensitive unittests, this function should be used.
   static Time NowFromSystemTime();
 
   // Returns the time for epoch in Unix-like system (Jan 1, 1970).
   static Time UnixEpoch() { return Time(0); }
 
   // Returns the maximum time, which should be greater than any reasonable time
   // with which we might compare it.
   static Time Max() { return Time(std::numeric_limits<int64_t>::max()); }
 
+  // Converts to/from internal values. The meaning of the "internal value" is
+  // completely up to the implementation, so it should be treated as opaque.
+  static Time FromInternalValue(int64_t value) V8_WARN_UNUSED_RESULT {

[Michael Starzinger, 2013/09/09 17:11:25]

Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.

[Benedikt Meurer, 2013/09/10 06:08:07]

Done.

+    return Time(value);
+  }
+  int64_t ToInternalValue() const V8_WARN_UNUSED_RESULT {

[Michael Starzinger, 2013/09/09 17:11:25]

Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.

[Benedikt Meurer, 2013/09/10 06:08:07]

Done.

+    return us_;
+  }
+
   // Converts to/from POSIX time specs.
   static Time FromTimespec(struct timespec ts);
   struct timespec ToTimespec() const;
 
   // Converts to/from POSIX time values.
   static Time FromTimeval(struct timeval tv);
   struct timeval ToTimeval() const;
 
   // Converts to/from Windows file times.
   static Time FromFiletime(struct _FILETIME ft);
@@ skipping 87 matching lines @@
   // Returns a platform-dependent high-resolution tick count. Implementation
   // is hardware dependent and may or may not return sub-millisecond
   // resolution.  THIS CALL IS GENERALLY MUCH MORE EXPENSIVE THAN Now() AND
   // SHOULD ONLY BE USED WHEN IT IS REALLY NEEDED.
   // This method never returns a null TimeTicks.
   static TimeTicks HighResNow();
 
   // Returns true if this object has not been initialized.
   bool IsNull() const { return ticks_ == 0; }
 
+  // Converts to/from internal values. The meaning of the "internal value" is
+  // completely up to the implementation, so it should be treated as opaque.
+  static TimeTicks FromInternalValue(int64_t value) V8_WARN_UNUSED_RESULT {

[Michael Starzinger, 2013/09/09 17:11:25]

Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.

[Benedikt Meurer, 2013/09/10 06:08:07]

Done.

+    return TimeTicks(value);
+  }
+  int64_t ToInternalValue() const V8_WARN_UNUSED_RESULT {

[Michael Starzinger, 2013/09/09 17:11:25]

Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.

[Benedikt Meurer, 2013/09/10 06:08:07]

Done.

+    return ticks_;
+  }
+
   TimeTicks& operator=(const TimeTicks other) {
     ticks_ = other.ticks_;
     return *this;
   }
 
   // Compute the difference between two times.
   TimeDelta operator-(const TimeTicks other) const {
     return TimeDelta::FromMicroseconds(ticks_ - other.ticks_);
   }
 
@@ skipping 44 matching lines @@
   int64_t ticks_;
 };
 
 inline TimeTicks operator+(const TimeDelta& delta, const TimeTicks& ticks) {
   return ticks + delta;
 }
 
 } }  // namespace v8::internal
 
 #endif  // V8_PLATFORM_TIME_H_