Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context.

test/cctest/test-strtod.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 414 matching lines @@
 }
 
 
 // Copied from v8.cc and adapted to make the function deterministic.
 static uint32_t DeterministicRandom() {
   // Random number generator using George Marsaglia's MWC algorithm.
   static uint32_t hi = 0;
   static uint32_t lo = 0;
 
   // Initialization values don't have any special meaning. (They are the result
-  // of two calls to random().)
+  // of two calls to rand().)
   if (hi == 0) hi = 0xbfe166e7;
   if (lo == 0) lo = 0x64d1c3c9;
 
   // Mix the bits.
   hi = 36969 * (hi & 0xFFFF) + (hi >> 16);
   lo = 18273 * (lo & 0xFFFF) + (lo >> 16);
   return (hi << 16) + (lo & 0xFFFF);
 }
 
 
 static const int kBufferSize = 1024;
 static const int kShortStrtodRandomCount = 2;
 static const int kLargeStrtodRandomCount = 2;
 
 TEST(RandomStrtod) {
+  srand(time(NULL));
   char buffer[kBufferSize];
   for (int length = 1; length < 15; length++) {
     for (int i = 0; i < kShortStrtodRandomCount; ++i) {
       int pos = 0;
       for (int j = 0; j < length; ++j) {
-        buffer[pos++] = random() % 10 + '0';
+        buffer[pos++] = rand() % 10 + '0';
       }
       int exponent = DeterministicRandom() % (25*2 + 1) - 25 - length;
       buffer[pos] = '\0';
       Vector<const char> vector(buffer, pos);
       double strtod_result = Strtod(vector, exponent);
       CHECK(CheckDouble(vector, exponent, strtod_result));
     }
   }
   for (int length = 15; length < 800; length += 2) {
     for (int i = 0; i < kLargeStrtodRandomCount; ++i) {
       int pos = 0;
       for (int j = 0; j < length; ++j) {
-        buffer[pos++] = random() % 10 + '0';
+        buffer[pos++] = rand() % 10 + '0';
       }
       int exponent = DeterministicRandom() % (308*2 + 1) - 308 - length;
       buffer[pos] = '\0';
       Vector<const char> vector(buffer, pos);
       double strtod_result = Strtod(vector, exponent);
       CHECK(CheckDouble(vector, exponent, strtod_result));
     }
   }
 }